Merged
Conversation
- Add spec.md with 3 user stories (API tests, error handling, CI) - Add plan.md with technical implementation details - Add tasks.md with TDD-based task breakdown (22 tasks) - Add requirements checklist (29 items, 26 pass) Branch: 002-sample-client
- Created standalone sample-client project - Implemented E2E integration tests for all API methods - Added GitHub Actions workflow for manual E2E testing - Updated specs and documentation - Verified all tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a complete end-to-end (E2E) testing setup for the WorldTides library, including a new sample client project configured for integration testing against the live World Tides API. It adds a new GitHub Actions workflow for E2E tests, updates the documentation for the new library version, and ensures the sample client uses the latest local build of the library.
The most important changes are:
E2E Testing Infrastructure:
.github/workflows/e2e.yml) to run E2E tests manually, publishing theworldtideslibrary to the local Maven repository before running tests in the sample client.E2ETest.ktthat validates all major API methods, checks error handling, and requires aWORLD_TIDES_API_KEYenvironment variable.Sample Client Project Setup:
sample-client/build.gradle.kts,sample-client/settings.gradle.kts). [1] [2]sample-client/gradlew,sample-client/gradlew.bat,sample-client/gradle/wrapper/gradle-wrapper.properties). [1] [2] [3]Documentation:
README.mdto reference the new2.0.0version of the library.