Skip to content

fix(rpc): eth_feeHistory base fee cannot be null #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benluelo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rpc): eth_feeHistory base fee cannot be null #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions rpc/backend/chain_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,15 @@ func (b *Backend) FeeHistory(
return nil, err
}

// the eth rpc spec requires a hex string to be returned for these values, so if they are nil then default them to 0x0
if oneFeeHistory.BaseFee == nil {
oneFeeHistory.BaseFee = big.NewInt(0)
}

if oneFeeHistory.NextBaseFee == nil {
oneFeeHistory.NextBaseFee = big.NewInt(0)
}

// copy
thisBaseFee[index] = (*hexutil.Big)(oneFeeHistory.BaseFee)
thisBaseFee[index+1] = (*hexutil.Big)(oneFeeHistory.NextBaseFee)
Expand Down