-
Notifications
You must be signed in to change notification settings - Fork 3
feat: enhance loading and error handling across components #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shivamhwp
wants to merge
19
commits into
main
Choose a base branch
from
feature/ux-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
795f287
feat: enhance document loading and error handling across components
shivamhwp 0c77275
get changes from main
shivamhwp c886bec
refactor: streamline document handling and improve loading/error states
shivamhwp b87db9e
get changes from main and resolve conflicts.
shivamhwp 10c42b3
get changes from main + resolve conflicts.
shivamhwp b062b96
chore: update subproject commit reference in MCP service
shivamhwp 3e246db
fix: clean up code formatting and improve observer logic in AppSideba…
shivamhwp c136900
get changes from main
shivamhwp e3deded
refactor: simplify sidebar component layout
shivamhwp d003490
refactor: clean up imports and improve layout in TopNav and AppSidebar
shivamhwp 7e92838
get changes from main
shivamhwp 9792752
chore: update project details and improve UI components
shivamhwp 4716dd0
fix: update .gitignore and refactor DocumentDialog and TopNav components
shivamhwp aeaff24
get changes from main
shivamhwp e1887ad
get changes from main
shivamhwp bb9cdd8
chore: update dependencies in bun.lock
shivamhwp 5ffe8a7
refactor: improve DocumentDialog and TopNav components
shivamhwp 66ed6e1
refactor: enhance DocumentDialog and TopNav components
shivamhwp b5adc1c
refactor: enhance user experience in components
shivamhwp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Submodule mcps
updated
4 files
| +2 −2 | vibz/Dockerfile | |
| +10 −8 | vibz/nginx.conf.template | |
| +3 −26 | vibz/start.ts | |
| +0 −1 | vibz/templates/convex-tanstackrouter-shadcn/vite.config.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Fix early null-return that makes Loading/Error UI unreachable; also gate the query when no attachments.
if (!documents?.length) return null;at Line 105 short-circuits before checkingisLoadingDocuments/isDocumentsError, so the spinner/error never render. There’s also a duplicate guard at Lines 110-111. Move the empty-docs guard to after the loading/error blocks and addenabledto the query so we don’t fetch (or show a spinner) whendocumentIdsis empty.Apply:
Also applies to: 105-106, 110-111, 112-135
🤖 Prompt for AI Agents