Skip to content

fix: do not overwrite app version with zero value#9

Merged
damiannolan merged 2 commits intorelease/v0.50.x-celestiafrom
damian/x/consensus-params-update
Mar 5, 2025
Merged

fix: do not overwrite app version with zero value#9
damiannolan merged 2 commits intorelease/v0.50.x-celestiafrom
damian/x/consensus-params-update

Conversation

@damiannolan
Copy link

Description

Addresses a bug where sending MsgUpdateParams in x/consensus would result in AppVersion: 0.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions

This comment has been minimized.

Copy link

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link this PR to the first changelog?

@damiannolan damiannolan merged commit 630a3c9 into release/v0.50.x-celestia Mar 5, 2025
42 of 43 checks passed
@damiannolan damiannolan deleted the damian/x/consensus-params-update branch March 5, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants