fix: do not overwrite app version with zero value#9
Merged
damiannolan merged 2 commits intorelease/v0.50.x-celestiafrom Mar 5, 2025
Merged
fix: do not overwrite app version with zero value#9damiannolan merged 2 commits intorelease/v0.50.x-celestiafrom
damiannolan merged 2 commits intorelease/v0.50.x-celestiafrom
Conversation
This comment has been minimized.
This comment has been minimized.
julienrbrt
approved these changes
Mar 5, 2025
julienrbrt
left a comment
There was a problem hiding this comment.
can we link this PR to the first changelog?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses a bug where sending
MsgUpdateParamsin x/consensus would result inAppVersion: 0.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change