chore: add gas_fee, sequence and address to checktx response #13
Closed
tac0turtle wants to merge 2 commits intomarko/core_changes_v3from
Closed
chore: add gas_fee, sequence and address to checktx response #13tac0turtle wants to merge 2 commits intomarko/core_changes_v3from
tac0turtle wants to merge 2 commits intomarko/core_changes_v3from
Conversation
tac0turtle
changed the title
damiannolan
reviewed
Mar 3, 2025
|
|
||
| // these fields are used in the priority mempool | ||
| bytes address = 15; | ||
| uint64 gas_fees = 16; |
There was a problem hiding this comment.
so this is the same as priority field? do we want to move away from that naming or keep it?
Author
There was a problem hiding this comment.
previously priority was arbitrary to gas it was based on gas and fees but there could be conflicting numbers because the app was unaware of the queue in comet. This way it allows comet to be more intelligent in ordering and overriding
Author
|
merged upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes cel-49
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments