refactor(notion-to-jsx): 타입 안전성 강화, Props 전달 컨벤션 통일#163
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Unit Test Report106 tests 106 ✅ 0s ⏱️ Results for commit add5029. |
Contributor
Coverage Report for packages/notion-to-utils
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
block.[type]콘텐츠 객체를 직접 받도록 통일 (CodeBlock, Image, Bookmark, Embed, Quote)null패턴으로 변경, extractHeadings 타입 가드 추가CONTENT_MAX_WIDTH상수 추출 및 중복skeletonWrapper스타일을 공통 모듈로 통합RichTextItem을notion-types에서 직접 import, Skeleton 와일드카드 import를 named import으로 변경변경된 파일
BlockRenderer.tsx- Props 전달 컨벤션 통일 (content object 패턴)CodeBlock.tsx,Image.tsx,Bookmark.tsx,Embed.tsx,Quote.tsx- content object Props 수용MemoizedComponents.tsx- memo comparator를 content object 구조에 맞게 업데이트LinkPreview.tsx- fetch 에러 핸들링 및 타입 안전성 개선Table.tsx,TableRow.tsx- sentinel value-1→null패턴extractHeadings.ts- 타입 가드 추가styles/layout.ts- CONTENT_MAX_WIDTH 상수 추출styles/loadingOverlay.css.ts- 공통 skeletonWrapper 스타일 추출테스트
pnpm build성공pnpm test52개 테스트 통과