`getDepositTx` is not properly typed

[cytadela8]

🌟 Feature Request

📝 Description

getDepositTx has return value Promise<any>. It should be properly typed.

zksync-ethers/src/adapters.ts

Line 782 in 6476368

}): Promise<any> {

🤔 Rationale

It seems to me this is not difficult to implement, as when I go 2 functions deep I can see things are typed properly.

📋 Additional Context

[danijelTxFusion]

@cytadela8 Thank you for mentioning this, it will be resolved.

[popzxc]

From what I understood, the type change in TS considered a breaking change.
Given that it's a nice-to-have, I'd suggest to not work on this for the time being.

Once this will be a concern, it would be better to come up with a well defined strategy similarly to viem, and only after that start altering types.

[cytadela8]

I see your point about avoiding breaking changes, but I disagree that fixing an any return type should be treated as a breaking change in the same way as altering well-defined, intentional types may be. Currently, consumers of this function have no type safety, meaning they have to make assumptions or manually cast values. By replacing any with a proper type, we reduce potential runtime errors and improve DX without removing any functionality. Existing valid casts / type assertions will still work.

I would like to point out that linked viem policy does not consider this kind of change a breaking change:

Changes to types in this repository are considered non-breaking and are usually released as patch semver changes (otherwise every type enhancement would be a major version!).

I think having a well-defined type strategy is valuable, but waiting until a full strategy is in place shouldn't block a small, clear improvement like this. If we were refactoring an entire module's types, that would be different—but here, it's just addressing an incomplete definition.