Skip to content

Commit 19cae6b

Browse files
Merge pull request #178 from zivid/2024-04-27-update-python-samples
Samples: Minor updates
2 parents 73465bc + 04e296b commit 19cae6b

6 files changed

Lines changed: 23 additions & 27 deletions

File tree

source/camera/advanced/capture_2d_and_3d.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ def _main() -> None:
2424

2525
print("Configuring 3D settings")
2626
settings = zivid.Settings()
27-
settings.engine = "phase"
27+
settings.engine = zivid.Settings.Engine.phase
2828
settings.acquisitions.append(zivid.Settings.Acquisition())
2929
settings.sampling.pixel = zivid.Settings.Sampling.Pixel.blueSubsample4x4
3030
settings.sampling.color = zivid.Settings.Sampling.Color.disabled
31-
settings.processing.resampling = zivid.Settings.Processing.Resampling.Mode.upsample2x2
31+
settings.processing.resampling.mode = zivid.Settings.Processing.Resampling.Mode.upsample2x2
3232

3333
if camera.info.model in [zivid.CameraInfo.Model.zividTwo, zivid.CameraInfo.Model.zividTwoL100]:
3434
print(

source/camera/basic/capture_2d_with_settings_from_yml.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,7 @@ def _options() -> argparse.Namespace:
1717
Arguments from user
1818
1919
"""
20-
parser = argparse.ArgumentParser(
21-
description=(
22-
"Balance the color of a 2D image\n"
23-
"Example:\n"
24-
"\t $ python color_balance.py path/to/settings.yml\n\n"
25-
"where path/to/settings.yml is the path to the 2D acquisition settings you want to find color balance for."
26-
),
27-
formatter_class=argparse.RawTextHelpFormatter,
28-
)
20+
parser = argparse.ArgumentParser(description=__doc__)
2921

3022
parser.add_argument(
3123
dest="path",

source/camera/basic/capture_hdr_complete_settings.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ def _main() -> None:
6060

6161
print("Configuring settings for capture:")
6262
settings = zivid.Settings()
63-
settings.engine = "phase"
64-
settings.sampling.color = "rgb"
65-
settings.sampling.pixel = "all"
63+
settings.engine = zivid.Settings.Engine.phase
64+
settings.sampling.color = zivid.Settings.Sampling.Color.rgb
65+
settings.sampling.pixel = zivid.Settings.Sampling.Pixel.blueSubsample2x2
6666
settings.region_of_interest.box.enabled = True
6767
settings.region_of_interest.box.point_o = [1000, 1000, 1000]
6868
settings.region_of_interest.box.point_a = [1000, -1000, 1000]
@@ -80,7 +80,7 @@ def _main() -> None:
8080
filters.outlier.removal.enabled = True
8181
filters.outlier.removal.threshold = 5.0
8282
filters.reflection.removal.enabled = True
83-
filters.reflection.removal.mode = "global"
83+
filters.reflection.removal.mode = zivid.Settings.Processing.Filters.Reflection.Removal.Mode.global_
8484
filters.cluster.removal.enabled = True
8585
filters.cluster.removal.max_neighbor_distance = 10
8686
filters.cluster.removal.min_area = 100
@@ -91,12 +91,14 @@ def _main() -> None:
9191
filters.hole.repair.enabled = True
9292
filters.hole.repair.hole_size = 0.2
9393
filters.hole.repair.strictness = 1
94+
resampling = settings.processing.resampling
95+
resampling.mode = zivid.Settings.Processing.Resampling.Mode.upsample2x2
9496
color = settings.processing.color
9597
color.balance.red = 1.0
9698
color.balance.blue = 1.0
9799
color.balance.green = 1.0
98100
color.gamma = 1.0
99-
settings.processing.color.experimental.mode = "automatic"
101+
settings.processing.color.experimental.mode = zivid.Settings.Processing.Color.Experimental.Mode.automatic
100102
print(settings)
101103

102104
print("Configuring acquisition settings different for all HDR acquisitions")

source/camera/basic/capture_tutorial.md

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -238,14 +238,14 @@ settings = zivid.Settings(acquisitions=[zivid.Settings.Acquisition(aperture=fnum
238238
Fully configured settings are demonstrated below.
239239

240240
([go to
241-
source](https://github.com/zivid/zivid-python-samples/tree/master//source/camera/basic/capture_hdr_complete_settings.py#L61-L112))
241+
source](https://github.com/zivid/zivid-python-samples/tree/master//source/camera/basic/capture_hdr_complete_settings.py#L61-L114))
242242

243243
``` sourceCode python
244244
print("Configuring settings for capture:")
245245
settings = zivid.Settings()
246-
settings.engine = "phase"
247-
settings.sampling.color = "rgb"
248-
settings.sampling.pixel = "all"
246+
settings.engine = zivid.Settings.Engine.phase
247+
settings.sampling.color = zivid.Settings.Sampling.Color.rgb
248+
settings.sampling.pixel = zivid.Settings.Sampling.Pixel.blueSubsample2x2
249249
settings.region_of_interest.box.enabled = True
250250
settings.region_of_interest.box.point_o = [1000, 1000, 1000]
251251
settings.region_of_interest.box.point_a = [1000, -1000, 1000]
@@ -263,7 +263,7 @@ filters.noise.repair.enabled = True
263263
filters.outlier.removal.enabled = True
264264
filters.outlier.removal.threshold = 5.0
265265
filters.reflection.removal.enabled = True
266-
filters.reflection.removal.mode = "global"
266+
filters.reflection.removal.mode = zivid.Settings.Processing.Filters.Reflection.Removal.Mode.global_
267267
filters.cluster.removal.enabled = True
268268
filters.cluster.removal.max_neighbor_distance = 10
269269
filters.cluster.removal.min_area = 100
@@ -274,12 +274,14 @@ filters.experimental.contrast_distortion.removal.threshold = 0.5
274274
filters.hole.repair.enabled = True
275275
filters.hole.repair.hole_size = 0.2
276276
filters.hole.repair.strictness = 1
277+
resampling = settings.processing.resampling
278+
resampling.mode = zivid.Settings.Processing.Resampling.Mode.upsample2x2
277279
color = settings.processing.color
278280
color.balance.red = 1.0
279281
color.balance.blue = 1.0
280282
color.balance.green = 1.0
281283
color.gamma = 1.0
282-
settings.processing.color.experimental.mode = "automatic"
284+
settings.processing.color.experimental.mode = zivid.Settings.Processing.Color.Experimental.Mode.automatic
283285
print(settings)
284286
print("Configuring acquisition settings different for all HDR acquisitions")
285287
exposure_values = _get_exposure_values(camera)
@@ -325,7 +327,7 @@ Check out
325327
for recommended .yml files tuned for your application.
326328

327329
([go to
328-
source](https://github.com/zivid/zivid-python-samples/tree/master//source/camera/basic/capture_hdr_complete_settings.py#L124-L129))
330+
source](https://github.com/zivid/zivid-python-samples/tree/master//source/camera/basic/capture_hdr_complete_settings.py#L126-L131))
329331

330332
``` sourceCode python
331333
settings_file = "Settings.yml"
@@ -338,7 +340,7 @@ settings_from_file = zivid.Settings.load(settings_file)
338340
You can also save settings to .yml file.
339341

340342
([go to
341-
source](https://github.com/zivid/zivid-python-samples/tree/master//source/camera/basic/capture_hdr_complete_settings.py#L124-L126))
343+
source](https://github.com/zivid/zivid-python-samples/tree/master//source/camera/basic/capture_hdr_complete_settings.py#L126-L128))
342344

343345
``` sourceCode python
344346
settings_file = "Settings.yml"

source/camera/info_util_other/camera_user_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def _options() -> argparse.Namespace:
1616
1717
"""
1818
parser = argparse.ArgumentParser()
19-
subparsers = parser.add_subparsers(dest="mode", help="Select mode")
19+
subparsers = parser.add_subparsers(dest="mode", help="Select mode", required=True)
2020
subparsers.add_parser(
2121
"read",
2222
help="read",

source/camera/maintenance/correct_camera_in_field.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ def _main() -> None:
9292
accuracy_estimate = correction.accuracy_estimate()
9393

9494
print(
95-
"If written to the camera, this correction can be expected to yield a dimension accuracy error of ",
96-
f"{accuracy_estimate.dimension_accuracy()*100:.3f} or better in the range of z=[{accuracy_estimate.z_min():.3f}, {accuracy_estimate.z_max():.3f}] across the full FOV.",
95+
"If written to the camera, this correction can be expected to yield a dimension accuracy error of",
96+
f"{accuracy_estimate.dimension_accuracy()*100:.3f}% or better in the range of z=[{accuracy_estimate.z_min():.3f}, {accuracy_estimate.z_max():.3f}] across the full FOV.",
9797
"Accuracy close to where the correction data was collected is likely better.",
9898
)
9999

0 commit comments

Comments
 (0)