zingo-cli --waitsync messages

[zancas]

Fails to detect messages that exist.

It would be helpful to target specific commits, wallet.dats, validator, and indexer versions.

[Oscar-Pepper]

This issue is specifically related to changes in PR #2146 due to issues found by @Tomas-M. I cannot create a repro for this. I have dont alot of testing for this and reviewed the code. There is not issue with the "messages" command the focus is on the --waitsync flag so we might want to update the issue details. The new waitsync code calls await_sync which is essentially the same as @Tomas-M 's implementation using "sync poll" but using the library internals so is cleaner and more stable, await_sync was already in use and works as intended. I have looked into possible sync poll bugs to no avail... i have dont alot of testing and the sync handle is always created and stored in the lightclient before the handle is awaited, reading the code clearly shows there can be no race condition here and my testing and debugging support this. I believe the reason why the non-interactive commands such as "messages" are not returning the expected info is due to sync hitting and error and returning early. @Tomas-M if you could provide info on whether you see a sync error in the times where the messages re not shown that would be really helpful.

[Tomas-M]

When the problem happened to me, I did not see any error messages. There was no indication of any sync error.
Nevertheless, as I replied in some other issue, I tried to reproduce this problem again and I was not able to do so.
It is possible that it was some mistake on my side :(

[zancas]

We have not been able to reproduce this. Please reopen this issue if the bug resurfaces.