Skip to content

Change input from CSV and Excel to one CSV #4

@danielvandersand

Description

@danielvandersand

When I add the 4 columns in the CSV that contains the information from the excel file, I would like to be able to only have to upload one CSV file. Right now, the following test cases are not passing:
Screenshot 2023-10-11 at 4 43 39 PM

Zach sent this quote in an email:

If you take a look at the error in the first screenshot, you'll see that the error occurs on line 310, but in the second screenshot you've commented out line 310. This indicates that the error must be occurring in a different file than the one shown in the second screenshot. Upon further inspecting the first, you can see the error is located in press-dash-main/test/lib_for_tests/press_user_utils.py, not press-dash-main/press_dash_lib/user_utils.py. So the test test_base_page is not testing the user_utils you modified, but the previous one, and hence throwing an error. To fix this you'll need to copy in the user_utils you modified into lib_for_tests.

Now for some context on why this error occurred. press-dash is a fork of root-dash, the general-purpose dashboard template. root-dash comes with its own array of tests. Some of these tests are designed to ensure that root-dash still functions properly for example use cases. There are two example use cases, one for press data and one for financial data. What happened is that because you modified the config for the press data, the code is no longer functioning for the example use. It's out of date.

So what should be done for this in the future? Well, honestly, for press-dash and other forks of root-dash we don't care if they work for other examples. They're supposed to work for their specific use case. So what should be done for any forks is to delete lib_for_tests, and rerun the tests. A number of tests will break. For these broken tests the filepaths that no longer exist should be redirected to ones that do. This is something that would be good to make a smooth part of the forking process.

What you should do are as follows:

  1. For now replace the press_user_utils.py in lib_for_tests with your own user_utils.
  2. Open an issue on github.com/zhafen/root-dash describing the error. Include a copy of my response to you as a quote.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions