unused parameter and circular import

[mircealungu]

zeeguu.core.model.video.find_or_create(...upload_index) is not used. remove it?

also, inside of the method we find this comment:

        # Import here to avoid circular dependency:
        # video -> youtube_api -> util -> compute_fk -> model -> video
        from zeeguu.core.youtube_api.youtube_api import (
            fetch_video_info,
            fetch_channel_info,
        )

this suggests that it should be the code that calls find_or_create that passes the video_info and channel_info

[silashoeyer]

Im pretty sure @tfnribeiro added the upload_index, so im not sure..

[tfnribeiro]

Okay, so I think I added that parameter to control if we wanted to create the video (but then not index to ES). The idea is that similarly to the articles, we sometimes create an object but we don't index it to the ElasticSearch - e.g. Articles the user open aren't searchable to other users.

When I added the parameter I didn't end up implementing that functionality, and I think the reason why is because with the articles we have a different call (outside of the Article creation):

So, that parameter is safe to remove, though I would probably move the indexing to somewhere outside the find_or_create, maybe a Video.index_to_es(self) and that is called after the video is stored.