Skip to content

Commit 809e07b

Browse files
zachficlaude
andcommitted
Rename bin/manager to bin/nodemanager
The "manager" binary name was a kubebuilder scaffold default. With two binaries now (nodemanager + nodemanager-agent), align the daemon binary name to match the project and the goreleaser output. Updated: Makefile, Dockerfile, CLAUDE.md, docs/deployment.md. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3511f59 commit 809e07b

File tree

4 files changed

+7
-9
lines changed

4 files changed

+7
-9
lines changed

.claude/CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ A controller that uses Kubernetes CRDs as a unified configuration source to mana
99
## Build & Test
1010

1111
```sh
12-
make build # → bin/manager
12+
make build # → bin/nodemanager + bin/nodemanager-agent
1313
make test # unit tests via envtest
1414
make test-e2e # e2e against Kind cluster
1515
make lint # golangci-lint

Dockerfile

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Build the manager binary
1+
# Build the nodemanager binary
22
FROM golang:1.21 AS builder
33
ARG TARGETOS
44
ARG TARGETARCH
@@ -28,13 +28,11 @@ COPY internal/controller/ internal/controller/
2828
RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} \
2929
go build \
3030
-ldflags "-X main.version=${VERSION} -X main.gitCommit=${GIT_COMMIT} -X main.buildDate=${BUILD_DATE} -X main.goos=${TARGETOS:-linux} -X main.goarch=${TARGETARCH}" \
31-
-a -o manager cmd/main.go
31+
-a -o nodemanager cmd/main.go
3232

33-
# Use distroless as minimal base image to package the manager binary
34-
# Refer to https://github.com/GoogleContainerTools/distroless for more details
3533
FROM gcr.io/distroless/static:nonroot
3634
WORKDIR /
37-
COPY --from=builder /workspace/manager .
35+
COPY --from=builder /workspace/nodemanager .
3836
USER 65532:65532
3937

40-
ENTRYPOINT ["/manager"]
38+
ENTRYPOINT ["/nodemanager"]

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ REGISTRY ?=
9898

9999
.PHONY: build
100100
build: manifests generate fmt vet ## Build manager and agent binaries.
101-
go build $(LD_FLAGS) -o bin/manager cmd/*.go
101+
go build $(LD_FLAGS) -o bin/nodemanager cmd/*.go
102102
go build $(LD_FLAGS) -o bin/nodemanager-agent ./cmd/agent/
103103

104104
.PHONY: build-agent

docs/deployment.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ source:
8787

8888
```sh
8989
make build
90-
# produces bin/manager
90+
# produces bin/nodemanager and bin/nodemanager-agent
9191
```
9292

9393
## Running as a systemd service (Linux)

0 commit comments

Comments
 (0)