refactor: update HorizontalBarrierPainter and TickIndicator to use dynamic rightMargin

Author: z-chu

lib/src/deriv_chart/chart/data_visualization/annotations/barriers/horizontal_barrier/horizontal_barrier_painter.dart

@@ -23,9 +23,6 @@ class HorizontalBarrierPainter<T extends HorizontalBarrier>
 
   late Paint _paint;
 
-  /// Right margin.
-  static const double rightMargin = 4;
-
   /// Distance between title area and label area.
   static const double _distanceBetweenTitleAndLabel = 16;
 
@@ -124,7 +121,7 @@ class HorizontalBarrierPainter<T extends HorizontalBarrier>
     final Rect labelArea = Rect.fromCenter(
       center: Offset(
           size.width -
-              rightMargin -
+              style.rightMargin -
               style.labelPadding -
               valuePainter.width / 2,
           y),

lib/src/deriv_chart/chart/data_visualization/annotations/barriers/horizontal_barrier/tick_indicator.dart

@@ -20,14 +20,15 @@ class TickIndicator extends HorizontalBarrier {
     String? id,
     HorizontalBarrierStyle? style,
     HorizontalBarrierVisibility visibility = HorizontalBarrierVisibility.normal,
+    bool longLine = false,
   }) : super(
           tick.quote,
           epoch: tick.epoch,
           id: id,
           style: style ??
               const HorizontalBarrierStyle(labelShape: LabelShape.pentagon),
           visibility: visibility,
-          longLine: false,
+          longLine: longLine,
         );
 }
 

lib/src/theme/painting_styles/barrier_style.dart

@@ -43,6 +43,7 @@ class HorizontalBarrierStyle extends BarrierStyle {
     this.labelShape = LabelShape.rectangle,
     this.labelHeight = 24,
     this.labelPadding = 4,
+    this.rightMargin = 4,
     Color color = const Color(0xFF00A79E),
     Color titleBackgroundColor = const Color(0xFF0E0E0E),
     this.secondaryBackgroundColor = const Color(0xFF607D8B),
@@ -78,6 +79,9 @@ class HorizontalBarrierStyle extends BarrierStyle {
   /// Padding of label.
   final double labelPadding;
 
+  /// Right margin of the label from the edge of the chart.
+  final double rightMargin;
+
   /// Whether to have a blinking dot animation where barrier and chart data
   /// are intersected.
   final bool hasBlinkingDot;
@@ -116,6 +120,7 @@ class HorizontalBarrierStyle extends BarrierStyle {
     LabelShape? labelShape,
     double? labelHeight,
     double? labelPadding,
+    double? rightMargin,
     Color? color,
     Color? titleBackgroundColor,
     Color? secondaryBackgroundColor,
@@ -132,6 +137,7 @@ class HorizontalBarrierStyle extends BarrierStyle {
         labelShape: labelShape ?? this.labelShape,
         labelHeight: labelHeight ?? this.labelHeight,
         labelPadding: labelPadding ?? this.labelPadding,
+        rightMargin: rightMargin ?? this.rightMargin,
         color: color ?? this.color,
         titleBackgroundColor: titleBackgroundColor ?? this.titleBackgroundColor,
         secondaryBackgroundColor: