Mana regen issue

[GoldenViking]

Mana regen is calculated wrong. Currently showing that I regen 142 mana while I really regen 58 mana.

Thanks for otherwise great addon!

[yutsuku]

Would love to fix it but this feature was hacked together very quickly by reading some parts of MaNGOS server files. It was due to lack of information on how it should really work. If you happen to stumble on reliable source on how mana per tick is calculated from Spirit for every class, that would help greatly.

[GoldenViking]

https://classic.wowhead.com/guides/classic-wow-stats-and-attributes-overview#spirit
https://classic.wowhead.com/guides/priest-healing-stat-priority-classic-wow#spirit

Here are a few formulas to more correctly calculate the mana regen from spirit =)

[yutsuku]

I've found pretty much same formula, however it is wrong as I get 25mana with 64 spirit on my test shaman. I should have 29,8 (round up or down?) according to those formulas.

[GoldenViking]

Found this, but not sure how accurate it is https://vanilla-wow.fandom.com/wiki/Spirit
As a lvl 43 preist, and 200 spirit, I regen 63 mana, which is correct according to 13 + (spirit / 4) mana per tick

[yutsuku]

Those were still wrong for my L37 Shaman with 64 Spirit and 52 Intellect at Kronos server. However I noticed few my mistakes when quickly translating c++ code into lua. Meaning Mana regeneration should be closer to accurate but its still off from real value

20fe849

Leaving open if anyone can come up with whats wrong with formulas and/or my test server