-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathconfig-reader.test.ts
More file actions
605 lines (510 loc) · 15.7 KB
/
config-reader.test.ts
File metadata and controls
605 lines (510 loc) · 15.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
import { describe, test, expect } from "bun:test"
import {
readFallbackModels,
resolveAgentForSession,
getFallbackModelsForSession,
normalizeFallbackModelsField,
} from "./config-reader"
describe("config-reader", () => {
describe("#given readFallbackModels", () => {
describe("#when agent has fallback_models as array", () => {
test("#then returns the array", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: [
"google/antigravity-claude-opus-4-6-thinking",
"github-copilot/claude-opus-4.6",
],
},
}
const result = readFallbackModels("opus", agents)
expect(result).toEqual([
"google/antigravity-claude-opus-4-6-thinking",
"github-copilot/claude-opus-4.6",
])
})
})
describe("#when agent has fallback_models as single string", () => {
test("#then normalizes to array", () => {
const agents = {
gemini: {
model: "google/antigravity-gemini-3.1-pro",
fallback_models: "github-copilot/gemini-3.1-pro-preview",
},
}
const result = readFallbackModels("gemini", agents)
expect(result).toEqual(["github-copilot/gemini-3.1-pro-preview"])
})
})
describe("#when agent has no fallback_models", () => {
test("#then returns empty array", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
},
}
const result = readFallbackModels("opus", agents)
expect(result).toEqual([])
})
})
describe("#when agents config is undefined", () => {
test("#then returns empty array", () => {
const result = readFallbackModels("opus", undefined)
expect(result).toEqual([])
})
})
describe("#when agent name does not exist in config", () => {
test("#then returns empty array", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: ["google/model"],
},
}
const result = readFallbackModels("nonexistent", agents)
expect(result).toEqual([])
})
})
describe("#when fallback_models is empty array", () => {
test("#then returns empty array", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: [],
},
}
const result = readFallbackModels("opus", agents)
expect(result).toEqual([])
})
})
})
describe("#given resolveAgentForSession", () => {
describe("#when explicit agent parameter is provided", () => {
test("#then returns normalized agent name", () => {
const result = resolveAgentForSession(
"ses_random_123",
"Opus"
)
expect(result).toBe("opus")
})
})
describe("#when explicit agent has leading/trailing whitespace", () => {
test("#then returns trimmed lowercase name", () => {
const result = resolveAgentForSession(
"ses_random_123",
" Sonnet "
)
expect(result).toBe("sonnet")
})
})
describe("#when no explicit agent but session ID contains agent name", () => {
test("#then detects agent from session ID", () => {
const result = resolveAgentForSession("ses_opus_work_456")
expect(result).toBe("opus")
})
})
describe("#when no explicit agent and session ID has no recognizable pattern", () => {
test("#then returns undefined", () => {
const result = resolveAgentForSession("ses_a1b2c3_4d5e6f")
expect(result).toBeUndefined()
})
})
describe("#when explicit agent is empty string", () => {
test("#then falls through to session ID detection", () => {
const result = resolveAgentForSession("ses_sonnet_task", "")
expect(result).toBe("sonnet")
})
})
})
describe("#given getFallbackModelsForSession", () => {
describe("#when agent is resolved and has fallback models", () => {
test("#then returns fallback models with primary model prepended", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: [
"google/antigravity-claude-opus-4-6-thinking",
],
},
}
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents
)
// Primary model is prepended — first thing to try when current model fails
expect(result).toEqual([
"anthropic/claude-opus-4-6",
"google/antigravity-claude-opus-4-6-thinking",
])
})
})
describe("#when fallback_models already contains the primary model", () => {
test("#then does not duplicate the primary model", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: ["google/model-a", "anthropic/claude-opus-4-6"],
},
}
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents
)
expect(result).toEqual(["google/model-a", "anthropic/claude-opus-4-6"])
})
})
describe("#when fallback_models is empty but primary model exists", () => {
test("#then returns empty (primary not injected when no explicit fallbacks)", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: [],
},
}
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents
)
// Empty fallback_models = user didn't opt into fallback, don't inject primary
expect(result).toEqual([])
})
})
describe("#when no agent resolved and no global config", () => {
test("#then returns empty array (no iterate-all-agents)", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: ["google/model-a"],
},
sonnet: {
model: "anthropic/claude-sonnet-4-6",
},
}
const result = getFallbackModelsForSession(
"ses_random_no_agent",
undefined,
agents
)
// Should NOT fall back to opus's models — that was the old bug
expect(result).toEqual([])
})
})
describe("#when no agent resolved and no agents have fallback models", () => {
test("#then returns empty array", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
},
}
const result = getFallbackModelsForSession(
"ses_random_no_agent",
undefined,
agents
)
expect(result).toEqual([])
})
})
describe("#when agents config is undefined", () => {
test("#then returns empty array", () => {
const result = getFallbackModelsForSession(
"ses_123",
"opus",
undefined
)
expect(result).toEqual([])
})
})
})
describe("#given getFallbackModelsForSession with global config", () => {
const globalModels = ["google/antigravity-claude-opus-4-6-thinking", "github-copilot/claude-opus-4.6"]
describe("#when agent has per-agent fallback_models", () => {
test("#then returns per-agent models with primary prepended, ignoring global", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: ["google/agent-specific-model"],
},
}
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents,
globalModels
)
expect(result).toEqual(["anthropic/claude-opus-4-6", "google/agent-specific-model"])
})
})
describe("#when agent has no per-agent config but global exists", () => {
test("#then returns global fallback models", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
},
}
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents,
globalModels
)
expect(result).toEqual(globalModels)
})
})
describe("#when neither per-agent nor global config exists", () => {
test("#then returns empty array", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
},
}
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents
)
expect(result).toEqual([])
})
})
describe("#when per-agent has empty fallback_models and global exists", () => {
test("#then returns global (empty per-agent does not override)", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: [],
},
}
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents,
globalModels
)
expect(result).toEqual(globalModels)
})
})
describe("#when agent is unresolved and global config exists", () => {
test("#then returns global fallback models", () => {
const result = getFallbackModelsForSession(
"ses_a1b2c3",
undefined,
undefined,
globalModels
)
expect(result).toEqual(globalModels)
})
})
describe("#when agent is unresolved and no global config", () => {
test("#then returns empty array", () => {
const result = getFallbackModelsForSession(
"ses_a1b2c3",
undefined,
undefined
)
expect(result).toEqual([])
})
})
describe("#when global fallback is empty array", () => {
test("#then returns empty array", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
},
}
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents,
[]
)
expect(result).toEqual([])
})
})
describe("#when agents is undefined but global exists", () => {
test("#then returns global fallback models", () => {
const result = getFallbackModelsForSession(
"ses_123",
"opus",
undefined,
globalModels
)
expect(result).toEqual(globalModels)
})
})
})
describe("#given normalizeFallbackModelsField adversarial inputs", () => {
describe("#when value is null", () => {
test("#then returns empty array", () => {
expect(normalizeFallbackModelsField(null)).toEqual([])
})
})
describe("#when value is undefined", () => {
test("#then returns empty array", () => {
expect(normalizeFallbackModelsField(undefined)).toEqual([])
})
})
describe("#when value is a number", () => {
test("#then returns empty array", () => {
expect(normalizeFallbackModelsField(42)).toEqual([])
})
})
describe("#when value is a boolean", () => {
test("#then returns empty array", () => {
expect(normalizeFallbackModelsField(true)).toEqual([])
})
})
describe("#when value is an object (not array)", () => {
test("#then returns empty array", () => {
expect(normalizeFallbackModelsField({ foo: "bar" })).toEqual([])
})
})
describe("#when value is 0 (falsy number)", () => {
test("#then returns empty array", () => {
expect(normalizeFallbackModelsField(0)).toEqual([])
})
})
describe("#when value is empty string", () => {
test("#then returns empty array (falsy)", () => {
expect(normalizeFallbackModelsField("")).toEqual([])
})
})
describe("#when array contains mixed types (strings and non-strings)", () => {
test("#then filters out non-string items silently", () => {
const mixed = ["google/model-a", 42, null, "openai/gpt-4o", undefined, { x: 1 }, true]
const result = normalizeFallbackModelsField(mixed)
expect(result).toEqual(["google/model-a", "openai/gpt-4o"])
})
})
describe("#when array contains only non-string items", () => {
test("#then returns empty array", () => {
expect(normalizeFallbackModelsField([42, null, true, {}])).toEqual([])
})
})
})
describe("#given readFallbackModels adversarial agent configs", () => {
describe("#when agent config is a string (not an object)", () => {
test("#then returns empty array", () => {
const agents = { opus: "not-an-object" }
expect(readFallbackModels("opus", agents as any)).toEqual([])
})
})
describe("#when agent config is a number", () => {
test("#then returns empty array", () => {
const agents = { opus: 42 }
expect(readFallbackModels("opus", agents as any)).toEqual([])
})
})
describe("#when agent config is null", () => {
test("#then returns empty array", () => {
const agents = { opus: null }
expect(readFallbackModels("opus", agents as any)).toEqual([])
})
})
describe("#when agent config is an array (not a plain object)", () => {
test("#then returns empty array", () => {
const agents = { opus: ["model-a", "model-b"] }
expect(readFallbackModels("opus", agents as any)).toEqual([])
})
})
describe("#when agents is empty object", () => {
test("#then returns empty array", () => {
expect(readFallbackModels("opus", {})).toEqual([])
})
})
})
describe("#given resolveAgentForSession edge cases", () => {
describe("#when session ID is empty string", () => {
test("#then returns undefined", () => {
expect(resolveAgentForSession("")).toBeUndefined()
})
})
describe("#when session ID contains only noise words", () => {
test("#then returns undefined", () => {
expect(resolveAgentForSession("ses_work_task_session")).toBeUndefined()
})
})
describe("#when session ID segment is exactly 2 characters", () => {
test("#then skips it (too short)", () => {
expect(resolveAgentForSession("ab_cd_ef")).toBeUndefined()
})
})
describe("#when session ID segment is exactly 3 characters", () => {
test("#then returns it (minimum valid length)", () => {
expect(resolveAgentForSession("ses_abc")).toBe("abc")
})
})
describe("#when session ID contains alphanumeric segments", () => {
test("#then skips segments with digits (alpha-only regex)", () => {
// "gpt4" contains a digit, so it fails /^[a-z][a-z-]*$/
expect(resolveAgentForSession("ses_gpt4_work")).toBeUndefined()
})
})
describe("#when session ID contains hyphens in agent name", () => {
test("#then splits on hyphens — hyphenated names become separate segments", () => {
// "my-agent" is split into ["my", "agent"] — "my" is 2 chars (too short),
// "agent" is not a noise word, so it matches
expect(resolveAgentForSession("ses_my-agent_work")).toBe("agent")
})
})
describe("#when explicit agent is whitespace-only", () => {
test("#then falls through to session ID detection", () => {
const result = resolveAgentForSession("ses_opus_task", " ")
expect(result).toBe("opus")
})
})
describe("#when session ID uses slash separators", () => {
test("#then splits on slashes and finds agent", () => {
expect(resolveAgentForSession("workspace/opus/task")).toBe("workspace")
})
})
describe("#when session ID has multiple valid segments", () => {
test("#then returns the first valid non-noise segment", () => {
// "ses" is noise, "builder" is first valid (>2 chars, alpha, not noise)
expect(resolveAgentForSession("ses_builder_opus")).toBe("builder")
})
})
})
describe("#given getFallbackModelsForSession case sensitivity", () => {
describe("#when event agent has different case than config key", () => {
test("#then resolves correctly because resolveAgentForSession lowercases", () => {
const agents = {
opus: {
model: "anthropic/claude-opus-4-6",
fallback_models: ["google/model-a"],
},
}
// eventAgent "OPUS" → resolveAgentForSession returns "opus" → matches config key
const result = getFallbackModelsForSession(
"ses_123",
"OPUS",
agents,
[]
)
// Primary model prepended as first fallback candidate
expect(result).toEqual(["anthropic/claude-opus-4-6", "google/model-a"])
})
})
describe("#when config key is uppercase but resolved agent is lowercase", () => {
test("#then returns empty (config keys are case-sensitive)", () => {
const agents = {
OPUS: {
model: "anthropic/claude-opus-4-6",
fallback_models: ["google/model-a"],
},
}
// resolveAgentForSession returns "opus" (lowercase), but config key is "OPUS"
const result = getFallbackModelsForSession(
"ses_123",
"opus",
agents,
[]
)
// agents["opus"] is undefined, so falls through
expect(result).toEqual([])
})
})
})
})