Skip to content

Comments

Add create_runtime fail hook test#3408

Open
fspv wants to merge 2 commits intoyouki-dev:mainfrom
fspv:e2e-create-runtime-fail
Open

Add create_runtime fail hook test#3408
fspv wants to merge 2 commits intoyouki-dev:mainfrom
fspv:e2e-create-runtime-fail

Conversation

@fspv
Copy link
Contributor

@fspv fspv commented Feb 15, 2026

Description

Implements a create_runtime fail hook test as a part of the #361. create_runtime hook replaces the deprecated prestart hook.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

#361
Similar prestart fail test #3406

Additional Context

Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
@fspv fspv mentioned this pull request Feb 15, 2026
13 tasks
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please consider consolidating the functions with other similar tests?

@fspv
Copy link
Contributor Author

fspv commented Feb 17, 2026

Hey, yes, will do. As discussed in #3406 it is probably worth opening a separate PR for that, because there are similar functions in other tests as well.

@utam0k
Copy link
Member

utam0k commented Feb 18, 2026

Hey, yes, will do. As discussed in #3406 it is probably worth opening a separate PR for that, because there are similar functions in other tests as well.

Sounds good. How about making this PR a draft until the separate PR is merged?

Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
@fspv fspv force-pushed the e2e-create-runtime-fail branch from f2c9b5f to 25d27c8 Compare February 18, 2026 12:35
@fspv fspv mentioned this pull request Feb 18, 2026
13 tasks
@fspv
Copy link
Contributor Author

fspv commented Feb 18, 2026

PR for deduplication of the helper methods is here: #3412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants