Open
Conversation
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
utam0k
reviewed
Feb 17, 2026
Member
utam0k
left a comment
There was a problem hiding this comment.
Could you please consider consolidating the functions with other similar tests?
Contributor
Author
|
Hey, yes, will do. As discussed in #3406 it is probably worth opening a separate PR for that, because there are similar functions in other tests as well. |
Member
Sounds good. How about making this PR a draft until the separate PR is merged? |
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
f2c9b5f to
25d27c8
Compare
Contributor
Author
|
PR for deduplication of the helper methods is here: #3412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements a create_runtime fail hook test as a part of the #361. create_runtime hook replaces the deprecated prestart hook.
Type of Change
Testing
Related Issues
#361
Similar prestart fail test #3406
Additional Context