Crash in pre-23 caused by vector drawables

[xiprox]

Discovered this just now while working on another app. While I haven't tested Youkai specifically, I'm pretty sure it applies. (See)

ImageViews with srcCompat are totally fine and this issue doesn't apply to them.

The fix is fairly simple:

class App : Application() {

    init {
        AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
    }
}

The above applies to general usage. Vector drawables used as, for example, drawableLeft on TextViews or Button icons still blow things up. We don't use button icons anyway so that aside, we will need to implement a solution for TextViews (at least, when we use them) along the lines of the following: http://stackoverflow.com/a/40250753/984061

[xiprox]

TextView vector fix implementation quick copypasta for later:

/**
 * A TextView that supports vector drawables.
 *
 * See: http://stackoverflow.com/questions/35761636/is-it-possible-to-use-vectordrawable-in-buttons-and-textviews-using-androiddraw
 */
class VectorCompatTextView : AppCompatTextView {

    constructor(context: Context, attrs: AttributeSet) : super(context, attrs) {
        init(context, attrs)
    }

    constructor(context: Context, attrs: AttributeSet, defStyleAttr: Int) : super(context, attrs, defStyleAttr) {
        init(context, attrs)
    }

    internal fun init(context: Context, attrs: AttributeSet?) {
        if (attrs == null) return

        val attributeArray = context.obtainStyledAttributes(
                attrs,
                R.styleable.VectorCompatTextView
        )

        var drawableLeft: Drawable? = null
        var drawableRight: Drawable? = null
        var drawableBottom: Drawable? = null
        var drawableTop: Drawable? = null

        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            drawableLeft = attributeArray.getDrawable(R.styleable.VectorCompatTextView_drawableLeftCompat)
            drawableRight = attributeArray.getDrawable(R.styleable.VectorCompatTextView_drawableRightCompat)
            drawableBottom = attributeArray.getDrawable(R.styleable.VectorCompatTextView_drawableBottomCompat)
            drawableTop = attributeArray.getDrawable(R.styleable.VectorCompatTextView_drawableTopCompat)
        } else {
            val drawableLeftId = attributeArray.getResourceId(R.styleable.VectorCompatTextView_drawableLeftCompat, -1)
            val drawableRightId = attributeArray.getResourceId(R.styleable.VectorCompatTextView_drawableRightCompat, -1)
            val drawableBottomId = attributeArray.getResourceId(R.styleable.VectorCompatTextView_drawableBottomCompat, -1)
            val drawableTopId = attributeArray.getResourceId(R.styleable.VectorCompatTextView_drawableTopCompat, -1)

            if (drawableLeftId != -1)
                drawableLeft = AppCompatResources.getDrawable(context, drawableLeftId)
            if (drawableRightId != -1)
                drawableRight = AppCompatResources.getDrawable(context, drawableRightId)
            if (drawableBottomId != -1)
                drawableBottom = AppCompatResources.getDrawable(context, drawableBottomId)
            if (drawableTopId != -1)
                drawableTop = AppCompatResources.getDrawable(context, drawableTopId)
        }

        setCompoundDrawablesWithIntrinsicBounds(drawableLeft, drawableTop, drawableRight, drawableBottom)
        attributeArray.recycle()
    }
}

<?xml version="1.0" encoding="utf-8"?>
<resources>

    <declare-styleable name="VectorCompatTextView">
        <attr name="drawableLeftCompat" format="reference"/>
        <attr name="drawableRightCompat" format="reference"/>
        <attr name="drawableTopCompat" format="reference"/>
        <attr name="drawableBottomCompat" format="reference"/>
    </declare-styleable>
</resources>

[xiprox]

The fix for TextView applies to EditText too. All we need to do is to extend AppCompatEditText instead and to rename VectorCompatTextView styleable to VectorCompatView or something.