Remove CliFx references and update exception handling in BuildWorker; add pragma warnings in test files.

Author: yldrefruz

ebuild.Tests/Unit/CliParserConverterTests.cs

@@ -1,7 +1,7 @@
 using NUnit.Framework;
 using System.Collections.Generic;
 using ebuild.cli;
-
+#pragma warning disable CS0649
 namespace ebuild.Tests.Unit
 {
     [TestFixture]
@@ -42,8 +42,10 @@ public void Dictionary_values_are_converted_to_int()
             parser.Parse(new[] { "cmd", "--map=foo=42", "--map=bar=7" });
             parser.ApplyParsedToCommands();
             var root = (TestDictRoot)parser.currentCommandChain.First!.Value;
-            Assert.That(root.Map.ContainsKey("foo") && root.Map["foo"] == 42);
-            Assert.That(root.Map.ContainsKey("bar") && root.Map["bar"] == 7);
+            Assert.That(root.Map!.ContainsKey("foo") && root.Map["foo"] == 42);
+            Assert.That(root.Map!.ContainsKey("bar") && root.Map["bar"] == 7);
         }
     }
 }
+
+#pragma warning restore CS0649

ebuild.Tests/Unit/CliParserSubcommandTests.cs

@@ -1,6 +1,6 @@
 using NUnit.Framework;
 using ebuild.cli;
-
+#pragma warning disable CS0649
 namespace ebuild.Tests.Unit
 {
     [TestFixture]
@@ -94,3 +94,4 @@ public void Nested_subcommand_opt_out_prevents_registration()
         }
     }
 }
+#pragma warning restore CS0649

ebuild.Tests/Unit/CliParserUnitTests.cs

@@ -1,7 +1,7 @@
 using NUnit.Framework;
 using System;
 using ebuild.cli;
-
+#pragma warning disable CS0649 // Field is never assigned to
 namespace ebuild.Tests.Unit
 {
     [TestFixture]
@@ -119,3 +119,4 @@ public void Short_option_attached_quoted_value_with_spaces_parses()
         }
     }
 }
+#pragma warning restore CS0649

ebuild/EBuild.cs

@@ -1,6 +1,5 @@
 using System.Reflection;
 using System.Text;
-using CliFx;
 using ebuild.api;
 using ebuild.api.Toolchain;
 using ebuild.cli;

ebuild/Modules/BuildGraph/BuildWorker.cs

@@ -1,4 +1,3 @@
-using CliFx.Exceptions;
 using ebuild.api;
 using ebuild.BuildGraph;
 using Microsoft.Extensions.Logging;
@@ -29,7 +28,7 @@ public async Task WorkOnNodesAsync(List<Node> nodes, CancellationToken cancellat
                 catch (Exception exception)
                 {
                     // If there was an error promote it to clifx exception
-                    throw new CliFxException($"Pre-build step \"{step.Name}\" failed: {exception.Message}", 1, false, exception);
+                    throw new Exception($"Pre-build step \"{step.Name}\" failed: {exception.Message}", exception);
                 }
             }
         }
@@ -57,10 +56,8 @@ await Parallel.ForEachAsync(
             if (exceptions.Count > 0)
             {
                 // Aggregate all exceptions and throw as CliFxException
-                throw new CliFxException(
+                throw new Exception(
                 $"Compilation of {Module.Name} failed with {exceptions.Count} source file uncompiled(s): {string.Join("; ", exceptions.Select(e => e.Message))}",
-                1,
-                false,
                 new AggregateException(exceptions)
                 );
             }
@@ -75,7 +72,7 @@ await Parallel.ForEachAsync(
                 }
                 catch (Exception ex)
                 {
-                    throw new CliFxException($"Linking failed: {ex.Message}", 1, false, ex);
+                    throw new Exception($"Linking failed: {ex.Message}", ex);
                 }
             }
         }
@@ -88,7 +85,7 @@ await Parallel.ForEachAsync(
             }
             catch (Exception ex)
             {
-                throw new CliFxException($"Copying shared library failed: {ex.Message}", 1, false, ex);
+                throw new Exception($"Copying shared library failed: {ex.Message}", ex);
             }
         }
         // 3rd run additional dependency nodes non-parallel
@@ -100,7 +97,7 @@ await Parallel.ForEachAsync(
             }
             catch (Exception ex)
             {
-                throw new CliFxException($"Processing additional dependency failed: {ex.Message}", 1, false, ex);
+                throw new Exception($"Processing additional dependency failed: {ex.Message}", ex);
             }
         }
 
@@ -116,7 +113,7 @@ await Parallel.ForEachAsync(
             catch (Exception exception)
             {
                 // If there was an error promote it to clifx exception
-                throw new CliFxException($"Post-build step \"{step.Name}\" failed: {exception.Message}", 1, false, exception);
+                throw new Exception($"Post-build step \"{step.Name}\" failed: {exception.Message}", exception);
             }
         }
 

ebuild/ebuild.csproj

@@ -7,7 +7,6 @@
         <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     </PropertyGroup>
     <ItemGroup>
-      <PackageReference Include="CliFx" Version="2.3.6" />
       <PackageReference Include="Microsoft.Data.Sqlite" Version="9.0.9" />
       <PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.0" />
       <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="9.0.0" />