Skip to content

SDK v3.6.3 Update for NTESVerifyCodeManagerDelegate breaks the main functionality interface of the service #9

@blitzdex27

Description

@blitzdex27

Hi, on v3.6.3, one of the delegate methods of NTESVerifyCodeManagerDelegate changed.

From:

- (void)verifyCodeValidateFinish:(BOOL)result validate:(NSString *_Nullable)validate message:(NSString *)message;

To:

- (void)verifyCodeValidateFinish:(BOOL)result validate:(NSString *_Nullable)validate message:(NSString *_Nullable)message captchaType:(NSString *_Nullable)captchaType;

It breaks the interface. Modifying the interface, especially one that involves the core functionality. might need a major version update and a notice to changes regarding the update. Because changing something like the above code will make the feature on apps that depends on this service to lose functionality.

Another thing, since this is the main handler delegate method, it might be better to make this method required instead of optional. This way, end users of this service will not be able to build their apps until they update their code.

Major Version: Indicates a significant change to the API or core functionality that may break existing code.
Minor Version: Indicates a new feature or enhancement that is backwards-compatible.
Patch Version: Indicates bug fixes or minor changes that don't affect the API or functionality.

https://semver.org

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions