Can't annotate contents inside frames

[kmike]

Extension doesn't work for pages with frameset/frame elements.
Annotating iframe data is also impossible.

[xtannier]

Do you have an example of such a page?
I remember having annotated framed pages.

[kmike]

Maybe pages itself can be annotated, but the contents in frame elements can't. This causes problems where main contents is in a frame. Some examples:

• http://cafepaprika.tripod.com/ - frame/frameset
• http://www.zarestaurant.com/about/index.php - most of the text is in iframe

[xtannier]

Maybe deep cloning the entire page would be a solution to this issue too? It we just add the content of the inserted file into the iframe.
That what we can see when we inspect the pages with the Firefox inspector.

[xtannier]

See http://stackoverflow.com/questions/9702406/how-to-deep-clone-iframe

[kmike]

If we delete frame/iframe elements and put their contents to an another HTML element it will change the original HTML page, and that's bad IMHO. You'll have to do the same in backend code, and it is not always what is wanted; also, it needs to be implement in backend code - you need several http requests and some HTML parsing/editing instead of just downloading a page.

What do you think about detecting such cases, adding some warning for them and maybe disabling frames/iframes (like we disable links)? If user is aware of this issue and willing to accept the challenge he can open the iframe contents in a new tab and annotate it in a separate annotation session.

[xtannier]

Well, some people won't care about changing the original page, it all depends on what you do with the annotations at the end of the day.
But detecting the frame and raising a warning is fine to me. If I have time one day I'll add an option to annotate frames by losing the orginal web page in the preferences.

[kmike]

Ok, thanks. FYI: I don't have plans to implement a warning soon; maybe I'll do that sometimes later.