From 5a3ec61f792de3454e9c1d8bd7b55aaabb91b33a Mon Sep 17 00:00:00 2001 From: Elephant Liu Date: Sat, 22 Nov 2025 11:29:35 +0800 Subject: [PATCH] refactor: use never instead of assert --- drow/parser.py | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drow/parser.py b/drow/parser.py index 53ef881..4ee5b4b 100644 --- a/drow/parser.py +++ b/drow/parser.py @@ -1,4 +1,4 @@ -from typing import Union, TypeVar, Generic, TypeAlias +from typing import Union, TypeVar, Generic, TypeAlias, Never from .annotation import ( SuccessResponse, ErrorResponse, @@ -50,8 +50,6 @@ def parse_query_response(self, resp: QueryResponse) -> QueryResult[T]: if resp["status"] == "error": self.parse_error(resp) - assert resp["status"] == "success", resp - data = resp["data"] if data["resultType"] == "string": @@ -65,7 +63,7 @@ def parse_query_response(self, resp: QueryResponse) -> QueryResult[T]: raise ParseError(f'unknown result type: {data["resultType"]}') - def parse_error(self, resp: ErrorResponse) -> None: + def parse_error(self, resp: ErrorResponse) -> Never: raise PrometheusError( f'error {resp["errorType"]}: {resp["error"]}' ) @@ -90,11 +88,7 @@ def parse_query_range_response( if resp["status"] == "error": self.parse_error(resp) - assert resp["status"] == "success", resp - data = resp["data"] - assert data["resultType"] == "matrix", resp - return self.parse_matrix(data) def parse_vector(self, data: VectorData) -> InstantVector[T]: @@ -121,8 +115,6 @@ def parse_query_value_response(self, resp: QueryResponse) -> T: if resp["status"] == "error": self.parse_error(resp) - assert resp["status"] == "success", resp - data = resp["data"] if data["resultType"] == "string":