fix(mini-window): coalesce resize calls to prevent resize storm during streaming#71
Open
fix(mini-window): coalesce resize calls to prevent resize storm during streaming#71
Conversation
…g streaming Route all ResizeWindowToContent() calls through RequestResize() which uses a _resizePending flag to coalesce multiple concurrent resize requests into a single layout+measure+resize per dispatcher tick. Previously, streaming translations with 3 concurrent services could trigger ~60 UpdateLayout+Measure+Resize cycles per second. With coalescing, concurrent requests from the same tick merge into one call. https://claude.ai/code/session_011z4iuKmi1kgo31n81A4uEH
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Add MiniWindowLongTextTests with 4 test cases for >30 word input: - InputDisplaysCorrectly: verifies long text accepted, captures baseline - TranslationResizesWindow: verifies window grows to fit results - StreamingProgressScreenshots: captures resize progression during streaming - WindowHeightWithinBounds: verifies 200-800 DIP height constraints Each test captures screenshots at key stages for visual regression comparison via VisualRegressionHelper (ThresholdText = 8%). https://claude.ai/code/session_011z4iuKmi1kgo31n81A4uEH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route all ResizeWindowToContent() calls through RequestResize() which
uses a _resizePending flag to coalesce multiple concurrent resize
requests into a single layout+measure+resize per dispatcher tick.
Previously, streaming translations with 3 concurrent services could
trigger ~60 UpdateLayout+Measure+Resize cycles per second. With
coalescing, concurrent requests from the same tick merge into one call.
https://claude.ai/code/session_011z4iuKmi1kgo31n81A4uEH