-
Notifications
You must be signed in to change notification settings - Fork 24
Description
While working on a game with a larger number of vertices, I found there was a performance bottleneck that was slowing down the rendering. When I investigated in the Chrome developer tools, I saw that toString was taking a lot of processing. I narrowed it down to this line: https://github.com/xem/W/blob/gh-pages/w.js#L337 For some reason when instantiating a DOMMatrix this way, there's some kind of implicit string conversion. (No idea why!❓)
Here was the change that improved the performance: morph-games/ring-rescue@2822a62#diff-9b7c0300e9f9c7a72e91a5f2890bd540663ae785b5c582a7b3ae15fac823bd6eR379
I can make a PR for this.
FWIW - The next bottleneck seems to be toFloat32Array, but I don't know if we can get around that without reimplementing some matrix math, which would take a lot of bytes.