Uninstall with `--deactivate` flag

[craigtommola]

user@server:/data/blogs$ wp plugin uninstall google-analyticator --deactivate
Deactivating 'google-analyticator'...
Warning: Plugin 'google-analyticator' is network active and must be deactivated with --network flag.
Uninstalled and deleted 'google-analyticator' plugin.
Success: Uninstalled 1 of 1 plugins.

Despite the warning that a plugin was network active and must be deactivated with the --network flag, the plugin was in fact deleted. No skin off my nose, but it seems contradictory or unintended, based on the warning message.

[janw-me]

A candidate for good-first-issue ?

[NielsdeBlaauw]

I'll be looking at this!

[kkoppenhaver]

As far as I can tell based on the conversation on #319, the patch needs to be re-applied and a test or two added.

The PR was closed during clean up, but appears to have been saved here: https://gist.github.com/danielbachhuber/f9aa4f759c7d57ff2663d07766241692

[michaelw85]

I just looked at the code and gist. I think this ticket should be closed.
I can't reproduce the scenario that a plugin is deactivated when the network flag is omitted from the command.

When you run wp plugin deactivate without a specific site url, this will execute implicitly on the primary site.
If you omit the network flag, I wonder if someone had the intention to turn off the plugin for all sites.
Currently, the warning provides instructions on what to do. This prevents someone from accidentally turning off a plugin site-wide when the intention was to turn it off for a single site (at least this gives you a moment to make a conscious choice).