Component-Oriented UI

[btzr-io]

Simplify UI with modular and reusable components:

Todo

• Fix translations preact-i18nline
• Fix settings Allow scroll for settings #110
• Handle Errors
• History Add a history button #104
• Improve UI / UX
• Fix fontawesome bug / icons
• Test / lighthouse test
• Responsive / mobile support
• Remove duplicated css / modules
• Fix empty library
• Port / Fix Reader

[btzr-io]

https://github.com/workhorsy/comic_book_reader/tree/polymer
is this branch still active?

[workhorsy]

This is a good idea. I have been looking into different libraries to do this: angular, react, vue, polymer, et cetera. Unfortunately right now I don't know enough about either to properly use them.

[workhorsy]

@btzr-io That polymer branch was accidentally pushed to github. I don't think there is anything even in it. It was just for a test. I'm not even sure if polymer is the right component library to use.

[btzr-io]

Ok, here's a basic implementation of react (not ready yet):
https://github.com/btzr-io/comic_book_reader/tree/react

Run for development

http://localhost:3000/

npm start

[btzr-io]

Now we just need to split UI into react-components:

• Menu
• Settings
• Welcome screen
• ...

[workhorsy]

Since you started porting to React, I've been looking into it more. Surprisingly it has a problem with its license. From what I understand, it uses the 3 clause BSD license with a patent rider clause added:

https://en.wikipedia.org/wiki/React_(JavaScript_library)#Licensing

This would make it so Facebook could terminate someones right to use React, if Facebook thinks they violated one of Facebook's patents. Or if they made a patent claim against Facebook.

It looks like there is a recent effort to fix this:
facebook/react#10191

Until this is resolved, there is no way I can support using React. You can continue changing it to use React if you want. But there is no way I can merge this into master with the license problem.

[btzr-io]

Well, we could use: preact

Preact

Fast 3kB alternative to React, with the same ES2015 API.

And if facebook ever fix that issue we could migrate to react:

Preact-compat

This module is a compatibility layer that makes React-based modules work with Preact, without any code changes.

[btzr-io]

Preact License: MIT License

[workhorsy]

I'll look into preact. Thanks

[workhorsy]

Right now I'm looking at a bunch of different component libraries. Here are a few requirements that will need to be met for us to select one:

• Must work with Internet Explorer 11, Chrome, Firefox, and Safari
• Must have a standard open source license such as MIT, GPL, AGPL, Apache, or 3 clause BSD
• Must be easy to setup on Linux, Mac, and Windows
• Size of the library does not matter, since we will need 3MB of code to uncompress Rar, Zip, Tar, and view PDF files.

[btzr-io]

I think preact it's a really good option (lightweight, fast, react-compatible, works with redux)
but I only can think about: react, riot, vue.js, polymer

License

Preact License: MIT License

Setup

https://github.com/developit/preact#getting-started

Preact-cli

Start building a Preact Progressive Web App in seconds

https://github.com/developit/preact-cli

Benchmark

http://developit.github.io/preact-perf

Browser support

[btzr-io]

Riot.js

Framework size comparison

Riot | 3.6.1 | 10.43kb

Browser support

Riot is supported by all modern browsers and it does not require any additional polyfill

License MIT

[codyhatch]

This would make it so Facebook could terminate someones right to use React, if Facebook thinks they violated one of Facebook's patents. Or if they made a patent claim against Facebook.

That's incorrect. Facebook cannot terminate your right to use React, they can only terminate your right to use any patents which they may or may not have on the concepts underlying React. And that termination does not happen if Facebook thinks you've violated their patents, only if you make a patent claim against Facebook. That's clarified explicitly here.

Q: Does termination of the additional patent grant in the Facebook BSD+Patents license cause the copyright license to also terminate?

A: No.

[j127]

they can only terminate your right to use any patents which they may or may not have on the concepts underlying React

I think that it isn't wise to have any of that hanging over software projects, especially as those PATENTS files get scattered throughout dependencies (Immutable, etc.). It creates a power imbalance, since Facebook could violate your patents, and then you would have to figure out what that untested file really means in practice.

Until those PATENTS files are removed, many companies won't be able to use open-source software that depends on Facebook libraries.

[workhorsy]

@btzr-io What do you think of polymer 2? It seems to be closest to what vanilla Web Components will be. The only down side I can see is that it still uses Bower, which is basically dead.