refactor: lazy evaluate for kalium config [WPB-23190]

[MohamadJaara]

https://wearezeta.atlassian.net/browse/WPB-23190

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

all values in kalium config are calculated at app startup but will be needed way later of never
for example

1. isWebSocketEnabledByDefaultis used only when adding a new user aka login
2. fileRestrictionState can be lazy calculated later when needed
3. shouldEncryptData is only needed during init and no need to have it around all the time

Solutions

1. remove isWebSocketEnabledByDefaultis since it is only used one time when logging in and it can be passed when needed
2. fileRestrictionState and shouldEncryptData as lambdaz that will be evaluated lazely

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[codecov]

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.45%. Comparing base (2d0e494) to head (3d4d63c).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...tication/create/code/CreateAccountCodeViewModel.kt	0.00%	2 Missing ⚠️
...entication/login/sso/LoginSSOViewModelExtension.kt	0.00%	2 Missing ⚠️
...ion/code/CreateAccountVerificationCodeViewModel.kt	0.00%	2 Missing ⚠️
...d/ui/authentication/login/sso/LoginSSOViewModel.kt	0.00%	1 Missing ⚠️
...id/ui/newauthentication/login/NewLoginViewModel.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4553      +/-   ##
===========================================
- Coverage    48.46%   48.45%   -0.01%     
===========================================
  Files          575      575              
  Lines        19825    19833       +8     
  Branches      3315     3315              
===========================================
+ Hits          9608     9610       +2     
- Misses        9202     9208       +6     
  Partials      1015     1015              

Files with missing lines	Coverage Δ
.../authentication/login/email/LoginEmailViewModel.kt	78.68% <100.00%> (+0.23%)	⬆️
...d/ui/authentication/login/sso/LoginSSOViewModel.kt	68.33% <0.00%> (ø)
...id/ui/newauthentication/login/NewLoginViewModel.kt	82.12% <0.00%> (ø)
...tication/create/code/CreateAccountCodeViewModel.kt	0.00% <0.00%> (ø)
...entication/login/sso/LoginSSOViewModelExtension.kt	2.77% <0.00%> (-0.17%)	⬇️
...ion/code/CreateAccountVerificationCodeViewModel.kt	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0e494...3d4d63c. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sbakhtiarov]

I am not sure there is any performance gain here. Does the whole refactoring of KaliumConfigs worth it?

[MohamadJaara]

my goal is to lazy evaluate anything that can should be calculated, this settings have some string manipulation, and yes it is not that much but still not needed on app startup

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud