From 0eecd01f74d2d01b30a5c4278542891acf646c7f Mon Sep 17 00:00:00 2001 From: Peter Goodspeed-Niklaus Date: Thu, 22 May 2025 13:41:00 +0200 Subject: [PATCH 1/3] Revert "feat: `ProposalQueue::from_committed_proposals` is public" This reverts commit abe690eced53ae42a5e38cbf575dcb23ec5ca0ce. --- openmls/src/group/core_group/proposals.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openmls/src/group/core_group/proposals.rs b/openmls/src/group/core_group/proposals.rs index e505f2bceb..f2b1f1f932 100644 --- a/openmls/src/group/core_group/proposals.rs +++ b/openmls/src/group/core_group/proposals.rs @@ -218,7 +218,7 @@ impl ProposalQueue { /// don't need filtering. /// This functions does the following checks: /// - ValSem200 - pub fn from_committed_proposals( + pub(crate) fn from_committed_proposals( ciphersuite: Ciphersuite, backend: &impl OpenMlsCryptoProvider, committed_proposals: Vec, From 04f570b8b0ea5da72d7f82adb4f6997b57086e2b Mon Sep 17 00:00:00 2001 From: Peter Goodspeed-Niklaus Date: Thu, 22 May 2025 13:41:04 +0200 Subject: [PATCH 2/3] Revert "feat: add a public getter for proposal store to public group" This reverts commit eb81a7fe9eda56195f05d15d4e989f5b022740f2. --- openmls/src/group/public_group/mod.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/openmls/src/group/public_group/mod.rs b/openmls/src/group/public_group/mod.rs index c8efb58809..02160922dd 100644 --- a/openmls/src/group/public_group/mod.rs +++ b/openmls/src/group/public_group/mod.rs @@ -329,10 +329,6 @@ impl PublicGroup { pub(crate) fn owned_encryption_keys(&self, leaf_index: LeafNodeIndex) -> Vec { self.treesync().owned_encryption_keys(leaf_index) } - - pub fn proposal_store(&self) -> &ProposalStore { - &self.proposal_store - } } // Test functions From a1b8833eb2fec32c1be657ba5d6f5b70ac215e44 Mon Sep 17 00:00:00 2001 From: Peter Goodspeed-Niklaus Date: Thu, 22 May 2025 13:41:04 +0200 Subject: [PATCH 3/3] Revert "feat: it is possible to cheaply get a `PublicGroup` from a `MlsGroup`" This reverts commit 421540346a254505155b376d2fb969809e7fb956. --- openmls/src/group/mls_group/mod.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/openmls/src/group/mls_group/mod.rs b/openmls/src/group/mls_group/mod.rs index f8a6799eda..57e13b6d33 100644 --- a/openmls/src/group/mls_group/mod.rs +++ b/openmls/src/group/mls_group/mod.rs @@ -177,12 +177,6 @@ pub struct MlsGroup { state_changed: InnerState, } -impl AsRef for MlsGroup { - fn as_ref(&self) -> &PublicGroup { - self.group.public_group() - } -} - impl MlsGroup { // === Configuration ===