fix: #113 clean up boolean flag help output

Author: tmm

.changeset/odd-kids-wink.md

@@ -0,0 +1,5 @@
+---
+'incur': patch
+---
+
+Fixed help output for boolean options so flags no longer showed `<boolean>` placeholders or redundant `(default: false)` text, including aliased flags.

src/Help.test.ts

@@ -148,6 +148,55 @@ describe('formatCommand', () => {
     expect(result).toContain('Verbosity level')
   })
 
+  test('omits value placeholders for boolean flag options', () => {
+    const result = Help.formatCommand('tool deploy', {
+      options: z.object({
+        dryRun: z.boolean().optional().describe('Preview without submitting.'),
+      }),
+    })
+
+    const line = result.split('\n').find((line) => line.includes('--dry-run'))
+
+    expect(line).toBe('  --dry-run  Preview without submitting.')
+  })
+
+  test('omits value placeholders for aliased boolean flag options', () => {
+    const result = Help.formatCommand('tool deploy', {
+      options: z.object({
+        dryRun: z.boolean().optional().describe('Preview without submitting.'),
+      }),
+      alias: { dryRun: 'd' },
+    })
+
+    const line = result.split('\n').find((line) => line.includes('--dry-run'))
+
+    expect(line).toBe('  --dry-run, -d  Preview without submitting.')
+  })
+
+  test('omits default false for boolean flag options', () => {
+    const result = Help.formatCommand('tool deploy', {
+      options: z.object({
+        dryRun: z.boolean().default(false).describe('Preview without submitting.'),
+      }),
+    })
+
+    const line = result.split('\n').find((line) => line.includes('--dry-run'))
+
+    expect(line).toBe('  --dry-run  Preview without submitting.')
+  })
+
+  test('shows default true for boolean flag options', () => {
+    const result = Help.formatCommand('tool deploy', {
+      options: z.object({
+        watch: z.boolean().default(true).describe('Watch for changes.'),
+      }),
+    })
+
+    const line = result.split('\n').find((line) => line.includes('--watch'))
+
+    expect(line).toBe('  --watch  Watch for changes. (default: true)')
+  })
+
   test('shows enum values for z.enum options', () => {
     const result = Help.formatCommand('tool deploy', {
       options: z.object({

src/Help.ts

@@ -275,8 +275,10 @@ function optionEntries(
     const type = resolveTypeName(field)
     const short = alias?.[key]
     const kebab = toKebab(key)
-    const flag = short ? `--${kebab}, -${short} <${type}>` : `--${kebab} <${type}>`
-    const defaultValue = extractDefault(field)
+    const valueHint = type === 'boolean' ? '' : ` <${type}>`
+    const flag = short ? `--${kebab}, -${short}${valueHint}` : `--${kebab}${valueHint}`
+    let defaultValue = extractDefault(field)
+    if (type === 'boolean' && defaultValue === false) defaultValue = undefined
     const deprecated = extractDeprecated(field)
     entries.push({ flag, description: (field as any).description ?? '', defaultValue, deprecated })
   }

src/Skill.ts

@@ -130,8 +130,7 @@ function renderGroup(
   prefix?: string | undefined,
 ): string {
   const groupDesc = prefix ? groups.get(prefix) : undefined
-  const fallbackDesc =
-    cmds.length === 1 && cmds[0]!.description ? cmds[0]!.description : undefined
+  const fallbackDesc = cmds.length === 1 && cmds[0]!.description ? cmds[0]!.description : undefined
   const desc = groupDesc ?? fallbackDesc
   const description = desc
     ? `${desc.replace(/\.$/, '')}. Run \`${title} --help\` for usage details.`

src/e2e.test.ts

@@ -1054,7 +1054,7 @@ describe('help', () => {
       Options:
         --limit, -l <number>               Max results (default: 20)
         --sort, -s <name|created|updated>  Sort field (default: name)
-        --archived <boolean>               Include archived (default: false)
+        --archived                         Include archived
 
       Global Options:
         --filter-output <keys>              Filter output by key paths (e.g. foo,bar.baz,a[0,3])
@@ -1082,7 +1082,7 @@ describe('help', () => {
 
       Options:
         --branch, -b <string>  Branch to deploy (default: main)
-        --dry-run <boolean>    Dry run mode (default: false)
+        --dry-run              Dry run mode
 
       Examples:
         app project deploy create staging                                    # Deploy staging from main
@@ -1918,7 +1918,7 @@ describe('env', () => {
 
       Options:
         --hostname, -h <string>  API hostname (default: api.example.com)
-        --web, -w <boolean>      Open browser (default: false)
+        --web, -w                Open browser
         --scopes <array>         OAuth scopes
 
       Global Options: