fix: skills add CTA command name

Author: tmm

.changeset/calm-peaches-talk.md

@@ -0,0 +1,5 @@
+---
+incur: patch
+---
+
+Fixed stale `skills add` CTA commands to use the invoked CLI name when running installed binaries directly, instead of falling back to `npx`.

src/Cli.test.ts

@@ -2646,6 +2646,31 @@ describe('skills staleness', () => {
     expect(output).toContain('skills add')
   })
 
+  test('uses displayName for stale skills CTA when invoked directly', async () => {
+    const savedArgv1 = process.argv[1]
+    const savedAgent = process.env.npm_config_user_agent
+    const savedExec = process.env.npm_execpath
+    try {
+      process.argv[1] = '/usr/local/bin/mc'
+      delete process.env.npm_config_user_agent
+      delete process.env.npm_execpath
+
+      __mockSkillsHash = '0000000000000000'
+      const cli = Cli.create({ name: 'my-cli', aliases: ['mc'] })
+      cli.command('ping', { description: 'Health check', run: () => ({ pong: true }) })
+
+      const { output } = await serve(cli, ['ping'])
+
+      expect(output).toContain('mc skills add')
+      expect(output).not.toContain('npx my-cli skills add')
+    } finally {
+      if (savedArgv1 === undefined) process.argv[1] = undefined as any
+      else process.argv[1] = savedArgv1
+      process.env.npm_config_user_agent = savedAgent
+      process.env.npm_execpath = savedExec
+    }
+  })
+
   test('merges skills CTA with command CTA', async () => {
     __mockSkillsHash = '0000000000000000'
     ;(process.stdout as any).isTTY = true

src/Cli.ts

@@ -555,13 +555,13 @@ async function serveImpl(
         const groups = new Map<string, string>()
         const entries = collectSkillCommands(commands, [], groups, options.rootCommand)
         if (Skill.hash(entries) !== stored) {
-          const runner = detectRunner()
-          const spec = SyncMcp.detectPackageSpecifier(name)
+          const command =
+            process.env.npm_config_user_agent || process.env.npm_execpath
+              ? `${detectRunner()} ${SyncMcp.detectPackageSpecifier(name)} skills add`
+              : `${displayName} skills add`
           skillsCta = {
             description: 'Skills are out of date:',
-            commands: [
-              { command: `${runner} ${spec} skills add`, description: 'sync outdated skills' },
-            ],
+            commands: [{ command, description: 'sync outdated skills' }],
           }
         }
       }

src/Completions.test.ts

@@ -1,8 +1,8 @@
+import { Cli, Completions, z } from 'incur'
 import { execFile, spawnSync } from 'node:child_process'
 import { chmod, mkdtemp, rm, writeFile } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
-import { Cli, Completions, z } from 'incur'
 
 const originalIsTTY = process.stdout.isTTY
 const originalEnv = { ...process.env }
@@ -338,8 +338,11 @@ _incur_complete_fake_cli`,
     await withFakeCli(async (dir) => {
       const output = await exec(
         'fish',
-        ['-c', `${Completions.register('fish', 'fake-cli')}
-complete --do-complete 'fake-cli '`],
+        [
+          '-c',
+          `${Completions.register('fish', 'fake-cli')}
+complete --do-complete 'fake-cli '`,
+        ],
         { ...process.env, PATH: `${dir}:${process.env.PATH ?? ''}` },
       )