This repository was archived by the owner on Nov 29, 2025. It is now read-only.
feat: add configurable default timeout for browser tools #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `default_timeout` in the browser initialization allowing dynamic timeout configuration via the `BROWSER_DEFAULT_TIMEOUT` environment variable. - Add an asynchronous context manager `timeout` to apply the default timeout across multiple browser operations. - Update browser tool functions to utilize the new `timeout` context. - Ensure default timeouts are applied for navigation, page actions, and observations, improving reliability in handling long-running browser tasks.
Author
|
@westonbrown was not able to reproduce the freeze with this change. Once the config manager PR is merged, I can update the usages of |
Owner
|
@niranjan94 , perfect thanks for the addition! Merging now and will do more testing over the coming days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #84
default_timeoutin the browser initialization allowing dynamic timeout configuration via theBROWSER_DEFAULT_TIMEOUTenvironment variable.timeoutto apply the default timeout across multiple browser operations.timeoutcontext.