Skip to content

[Bug]: <Helmet> not adding <base> elements in v70.4 #8281

@vegerot

Description

@vegerot

Version

System:
    OS: macOS 26.2
    CPU: (12) arm64 Apple M3 Pro
    Memory: 201.20 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 141.0.7390.124
    Firefox Developer Edition: 147.0
    Safari: 26.2
    Safari Technology Preview: 26.0
  npmPackages:
    @edenx/app-tools: 1.70.4 => 1.70.4 
    @edenx/plugin-fetch: 1.70.4 => 1.70.4 
    @edenx/plugin-slardar-web: 1.70.4 => 1.70.4 
    @edenx/plugin-starling-intl: 1.70.4 => 1.70.4 
    @edenx/runtime: 1.70.4 => 1.70.4 
    @edenx/tsconfig: 1.70.4 => 1.70.4

Details

Using v70.3, this code worked as expected

// src/routes/layout.tsx

const Layout = ()=> {
  // ...
  return (
    // ...
    <OpenAllLinksInNewTab />
  )
}

const OpenAllLinksInNewTab = () => {
	return (
		<Helmet>
			<base target="_blank" />
			<style className="@@@ test">
				YOU SHOULD SEE ME
			</style>
		</Helmet>
	);
};
npmPackages:
    @edenx/app-tools: 1.70.3 => 1.70.3 
    @edenx/plugin-fetch: 1.70.3 => 1.70.3 
    @edenx/plugin-slardar-web: 1.70.3 => 1.70.3 
    @edenx/plugin-starling-intl: 1.70.3 => 1.70.3 
    @edenx/runtime: 1.70.3 => 1.70.3 
    @edenx/tsconfig: 1.70.3 => 1.70.3 
Image

However, changing my packages to

  npmPackages:
    @edenx/app-tools: 1.70.4 => 1.70.4 
    @edenx/plugin-fetch: 1.70.4 => 1.70.4 
    @edenx/plugin-slardar-web: 1.70.4 => 1.70.4 
    @edenx/plugin-starling-intl: 1.70.4 => 1.70.4 
    @edenx/runtime: 1.70.4 => 1.70.4 
    @edenx/tsconfig: 1.70.4 => 1.70.4 
Image

note the <style> tag works but not <base>.

I didn't make any other code changes. On 70.3 it worked, and on 70.4 it stopped working

Reproduce link

Sorry, I didn't make one yet :( . I sent a maximum repro link on Lark

Reproduce Steps

  1. Create SSR project with v70.3
  2. Add <Helmet><base target="_blank" /> to your code
  3. Note that it shows in <head>
  4. Upgrade to v70.4
  5. Note that the tag isn't in <head>

P.S. I haven't bisected yet, but I bet the bug was introduced in a0ae8e5

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions