Non-idiomatic construction of lang-ext collections

[louthy]

https://github.com/wdolek/benchmarkator/blob/master/src/Benchmarkator.Collections/Contains/ImmutableContainsFalse.cs#L48

Although this is totally a legitimate way to create the collections, this is more idiomatic:

    using static LanguageExt.Prelude;

   ...

    _langExtImmutableArray = Array(secondHalf);
    _langExtImmutableHashSet = HashSet(secondHalf);
    _langExtImmutableList = List(secondHalf);
    _langExtImmutableSet = Set(secondHalf);

[wdolek]

@louthy Hi, thanks for mentioning this (and sorry it took me ages to get to this).

Looks like code you suggested is no more valid since all factory methods now have signature like ...(T x, params T[] xs). (One tiny rant from my side - it's really unfortunate to name arguments as x or xs 🤷, but that's how FP rolls I guess)

How would you instantiate collections these days?

• keep using constructors, new Arr(secondHalf)
• using Prelude, Array<T>().AddRange(secondHalf)
• using Prelude, Array(secondHalf[0], secondHalf[1..]) uff 😕