Issues with new astroquery version

[wbalmer]

Getting a few issues which I think are related to the new astroquery version >0.4.7.

First the ID column from Simbad.query_objectids was made lowercase, so Simbad.query_objectids(self.target_name)['ID'] returns a KeyError: 'ID' on initialization at line 321. Same for RA and DEC.

I also, upon fixing these errors, get a keyerror because the gaia async queries return empty tables on this version. If i explicitly set the requirement astroquery<=0.4.7 neither type of issue occurs.

For now I will be making this requirement explicit in the requirements.txt fa37027 but I'll need to look into a better fix.

[wbalmer]

I created version 0.5.0.post1 c81422a and uploaded it to pypi to ensure stability.

[wbalmer]

This should be fixed with #59 from @tomasstolker (thank you!)

Unfortunately, I think it creates a breaking version requirement for astroquery either way, so to be safe we'll want to require astroquery >=0.4.9 . If I'm on commit #34b1c9f with e.g. astroquery=0.4.6, I get the following error (included in case a user needs to search it)

[BACKTRACKS INFO]: Examining object = 1 in input file.
[BACKTRACKS INFO]: Resolved the target star '2MASS J06022455-1634494' in Simbad!

---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
Cell In[2], line 1
----> 1 track = System(target_name="2MASS J06022455-1634494",
      2                candidate_file="0602cc1.csv",
      3                nearby_window=0.5,
      4                fileprefix='[./](http://localhost:8888/lab/tree/backtracks/docs/)')

File [~/backtracks/backtracks/backtracks.py:181](http://localhost:8888/lab/tree/backtracks/docs/backtracks/backtracks/backtracks.py#line=180), in System.__init__(self, target_name, candidate_file, nearby_window, fileprefix, ndim, **kwargs)
    178             col.mask = np.isnan(col)
    180 else:
--> 181     self.nearby, self.gaia_id, target_gaia = self.query_astrometry(nearby_window)
    183     target_table = fits.BinTableHDU(target_gaia)
    184     nearby_table = fits.BinTableHDU(self.nearby)

File [~/backtracks/backtracks/backtracks.py:345](http://localhost:8888/lab/tree/backtracks/docs/backtracks/backtracks/backtracks.py#line=344), in System.query_astrometry(self, nearby_window)
    343 # get Gaia source ID
    344 gaia_id = None
--> 345 for id_name in simbad_query['ids'][0].split('|'):
    346     if f'Gaia {self.gaia_release}' in id_name:
    347         gaia_id = int(id_name.replace(f'Gaia {self.gaia_release}', ''))

File [~/miniconda3/envs/backtracks/lib/python3.11/site-packages/astropy/table/table.py:2061](http://localhost:8888/lab/tree/backtracks/docs/miniconda3/envs/backtracks/lib/python3.11/site-packages/astropy/table/table.py#line=2060), in Table.__getitem__(self, item)
   2059 def __getitem__(self, item):
   2060     if isinstance(item, str):
-> 2061         return self.columns[item]
   2062     elif isinstance(item, (int, np.integer)):
   2063         return self.Row(self, item)

File [~/miniconda3/envs/backtracks/lib/python3.11/site-packages/astropy/table/table.py:264](http://localhost:8888/lab/tree/backtracks/docs/miniconda3/envs/backtracks/lib/python3.11/site-packages/astropy/table/table.py#line=263), in TableColumns.__getitem__(self, item)
    253 """Get items from a TableColumns object.
    254 
    255 ::
   (...)
    261   tc[1:3] # <TableColumns names=('b', 'c')>
    262 """
    263 if isinstance(item, str):
--> 264     return OrderedDict.__getitem__(self, item)
    265 elif isinstance(item, (int, np.integer)):
    266     return list(self.values())[item]

KeyError: 'ids'

[tomasstolker]

I think the 'ids' is the only thing that I forgot to change. All other parts should be compatible with both the old and new astroquery version. So we could make it independent of the astroquery version?