SVG demo image(s)

[thibaudcolas]

When implementing #457 in #506 we somehow skipped having SVG images in the demo. We need one or two added for testing purposes.

Sample issue encountered by @laymonage during a live demo of the bakery’s snippet model:

AttributeError: 'SvgImage' object has no attribute 'has_alpha'

SVG images earmarked in #457:

• ImageBlock -> https://svgsilh.com/image/1294246.html
• Author -> https://svgsilh.com/image/307076.html

[Nightwing-77]

i explored the codebase for this issue, could it be that the svg image is being treated as a jpeg image !?!
this is the only place where 'has_alpha' has been used
https://github.com/wagtail/wagtail/blob/2c0376f953d1bf8f06b936e709def8f834592cac/wagtail/images/models.py#L1109

[Nightwing-77]

the issue could be in the image conversion logic!

[ankit02327]

I would like to take up this issue and will share updates as I make progress.
I will investigate how SVG images are handled in the demo and propose a fix.

[ankit02327]

I’ve been able to reliably reproduce this issue in a clean Wagtail project.

Firstly I enabled SVG support via WAGTAILIMAGES_EXTENSION
Then I uploaded a valid svg image.
I rendered it using :
{% image page.hero_image format-jpeg width-200 %}
and this caused the crash :

I'll investigate a proper fix - either guarding the has_aplha call for SVG inputs or ensuring a safe conversion path before alpha detection.

I'll share updates as I make progress.

[thibaudcolas]

I think I should reiterate - this issue is about our demo site missing SVG images to test the site with. I don’t think there’s anything to investigate or fix anywhere here. We just need someone to take the time to update the demo with one or two SVG images, to facilitate testing / demoing of Wagtail’s SVG support with this site.

[ankit02327]

Thanks for the clarification. I can work on adding one or two SVG images to the demo site for testing. I’ll open a PR shortly.

[thibaudcolas]

#630 now does the bare minimum of having the files inside the repository. Now the next step is to actually use those images within the contents of the site. Perhaps on the About page? Or a blog page? Not sure. There will be changes needed to the site configuration to allow SVG images, and to the rendering too.

[ankit02327]

I can take this on — I’ll try adding the SVGs to an existing page (maybe the About page) and look into the config changes needed to allow SVG uploads and rendering.