From 1d20d12f3d812229460a30964948f44b04254268 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Mon, 3 Feb 2020 14:24:13 -0700 Subject: [PATCH 01/15] change text --- src/app/app.component.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/app.component.html b/src/app/app.component.html index 139e8f7..7e26506 100644 --- a/src/app/app.component.html +++ b/src/app/app.component.html @@ -383,7 +383,7 @@ - {{ title }} app is running! + {{ title }} app is running yeah! Date: Mon, 3 Feb 2020 14:32:19 -0700 Subject: [PATCH 02/15] use xvfb --- .github/workflows/pull-request.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 8dc1085..3fb0c4b 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -4,15 +4,16 @@ on: pull_request jobs: build: - runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@master - with: - node-version: 12.x - - name: Install - run: npm ci - - name: E2E - run: npm run se2e + - uses: actions/checkout@v2 + - uses: actions/setup-node@master + with: + node-version: 12.x + - name: Install + run: npm ci + - name: E2E + uses: GabrielBB/xvfb-action@v1.0 + with: + run: npm run se2e From eb928ade0297373510ce083132627da339d1b98e Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Mon, 3 Feb 2020 14:36:05 -0700 Subject: [PATCH 03/15] try mac --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 3fb0c4b..423e4a3 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -4,7 +4,7 @@ on: pull_request jobs: build: - runs-on: ubuntu-latest + runs-on: macos-latest steps: - uses: actions/checkout@v2 From 8619b86b056c1883702dffd4677f07c0072a8d6d Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Thu, 6 Feb 2020 15:26:59 -0700 Subject: [PATCH 04/15] test: Send email --- .github/workflows/pull-request.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 423e4a3..c5d31d1 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -17,3 +17,17 @@ jobs: uses: GabrielBB/xvfb-action@v1.0 with: run: npm run se2e + - name: Email results + uses: dawidd6/action-send-mail@master + with: + server_address: smtp.gmail.com + server_port: 465 + username: ${{secrets.MAIL_USERNAME}} + password: ${{secrets.MAIL_PASSWORD}} + subject: E2E results + # Literal body: + body: E2E job of ${{github.repository}} completed successfully! + to: wade.w.wilkey@gmail.com + from: Luke Skywalker + # Optional content type: + content_type: text/html From c79b0197eb95f50928cf38bd64788fa10cbfaf6f Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Thu, 6 Feb 2020 15:30:43 -0700 Subject: [PATCH 05/15] fix: Indentation --- .github/workflows/pull-request.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index c5d31d1..4a8e147 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -19,15 +19,15 @@ jobs: run: npm run se2e - name: Email results uses: dawidd6/action-send-mail@master - with: - server_address: smtp.gmail.com - server_port: 465 - username: ${{secrets.MAIL_USERNAME}} - password: ${{secrets.MAIL_PASSWORD}} - subject: E2E results - # Literal body: - body: E2E job of ${{github.repository}} completed successfully! - to: wade.w.wilkey@gmail.com - from: Luke Skywalker - # Optional content type: - content_type: text/html + with: + server_address: smtp.gmail.com + server_port: 465 + username: ${{secrets.MAIL_USERNAME}} + password: ${{secrets.MAIL_PASSWORD}} + subject: E2E results + # Literal body: + body: E2E job of ${{github.repository}} completed successfully! + to: wade.w.wilkey@gmail.com + from: Luke Skywalker + # Optional content type: + content_type: text/html From 07f97e304be014e2d1ca6d6cdb414852ef8f0158 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Thu, 6 Feb 2020 16:44:25 -0700 Subject: [PATCH 06/15] try out send email action --- .github/workflows/pull-request.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 4a8e147..dcd9c22 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -18,16 +18,13 @@ jobs: with: run: npm run se2e - name: Email results - uses: dawidd6/action-send-mail@master + uses: wadeww/send-email-action@master with: server_address: smtp.gmail.com server_port: 465 username: ${{secrets.MAIL_USERNAME}} password: ${{secrets.MAIL_PASSWORD}} subject: E2E results - # Literal body: body: E2E job of ${{github.repository}} completed successfully! to: wade.w.wilkey@gmail.com - from: Luke Skywalker - # Optional content type: - content_type: text/html + from: meeee From 014ac51012211a7c74ec2489c95e71e2ad5ce6c3 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Thu, 6 Feb 2020 16:55:15 -0700 Subject: [PATCH 07/15] test: Add comment so I can push something --- se2e/test.e2e-spec.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/se2e/test.e2e-spec.ts b/se2e/test.e2e-spec.ts index 94b4fb2..3b4f463 100644 --- a/se2e/test.e2e-spec.ts +++ b/se2e/test.e2e-spec.ts @@ -40,6 +40,7 @@ describe("hi", () => { it("Should launch the application and open a window", async () => { const count = await app.client.getWindowCount(); + console.log('hi'); expect(count).to.equal(1); }); From 8eebc1facac592da61b3322f67bcf06e475aa32c Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Fri, 7 Feb 2020 08:43:14 -0700 Subject: [PATCH 08/15] test: Remove comment --- se2e/test.e2e-spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/se2e/test.e2e-spec.ts b/se2e/test.e2e-spec.ts index 3b4f463..94b4fb2 100644 --- a/se2e/test.e2e-spec.ts +++ b/se2e/test.e2e-spec.ts @@ -40,7 +40,6 @@ describe("hi", () => { it("Should launch the application and open a window", async () => { const count = await app.client.getWindowCount(); - console.log('hi'); expect(count).to.equal(1); }); From f4cc5c9ba4dd40516671e5222e6cbdea18e5f678 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Fri, 7 Feb 2020 09:23:28 -0700 Subject: [PATCH 09/15] chore: Try job details in body --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index dcd9c22..2ab1f5b 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -25,6 +25,6 @@ jobs: username: ${{secrets.MAIL_USERNAME}} password: ${{secrets.MAIL_PASSWORD}} subject: E2E results - body: E2E job of ${{github.repository}} completed successfully! + body: E2E tests against ${{github.ref}}: ${{job.status}} to: wade.w.wilkey@gmail.com from: meeee From c2938cb4acc67056e2eb1ab3840068ba4413f957 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Fri, 7 Feb 2020 09:28:22 -0700 Subject: [PATCH 10/15] fix: yml syntax --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 2ab1f5b..e99b3ca 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -25,6 +25,6 @@ jobs: username: ${{secrets.MAIL_USERNAME}} password: ${{secrets.MAIL_PASSWORD}} subject: E2E results - body: E2E tests against ${{github.ref}}: ${{job.status}} + body: E2E tests against ${{github.ref}} Status ${{job.status}} to: wade.w.wilkey@gmail.com from: meeee From ecd93ac3c70958de864d120fbf0d17766128a9c3 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Fri, 7 Feb 2020 10:12:13 -0700 Subject: [PATCH 11/15] test --- se2e/test.e2e-spec.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/se2e/test.e2e-spec.ts b/se2e/test.e2e-spec.ts index 94b4fb2..6241920 100644 --- a/se2e/test.e2e-spec.ts +++ b/se2e/test.e2e-spec.ts @@ -41,6 +41,7 @@ describe("hi", () => { it("Should launch the application and open a window", async () => { const count = await app.client.getWindowCount(); expect(count).to.equal(1); + console.log('hi'); }); it("should find new component span", async () => { From 7aaee55edb20f760686b6bc07ed602fec34632e6 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Mon, 10 Feb 2020 10:53:39 -0700 Subject: [PATCH 12/15] log window size --- se2e/test.e2e-spec.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/se2e/test.e2e-spec.ts b/se2e/test.e2e-spec.ts index 6241920..92123eb 100644 --- a/se2e/test.e2e-spec.ts +++ b/se2e/test.e2e-spec.ts @@ -28,6 +28,15 @@ describe("hi", () => { startTimeout: 20000, chromeDriverLogPath: "../chromedriverlog.txt" }); + + const bounds = app.browserWindow.getBounds(); + + console.log('Window Size:', bounds.width, bounds.height); + app.browserWindow.maximize(); + + const maxBounds = app.browserWindow.getBounds(); + console.log('Max Window Size:', maxBounds.width, maxBounds.height); + await app.start(); await app.client.waitUntilWindowLoaded(); }); From 3408dcbe3d8576d12d254e8454d5b4b500b9d696 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Mon, 10 Feb 2020 10:56:16 -0700 Subject: [PATCH 13/15] log window size --- se2e/test.e2e-spec.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/se2e/test.e2e-spec.ts b/se2e/test.e2e-spec.ts index 92123eb..7651254 100644 --- a/se2e/test.e2e-spec.ts +++ b/se2e/test.e2e-spec.ts @@ -29,6 +29,9 @@ describe("hi", () => { chromeDriverLogPath: "../chromedriverlog.txt" }); + await app.start(); + await app.client.waitUntilWindowLoaded(); + const bounds = app.browserWindow.getBounds(); console.log('Window Size:', bounds.width, bounds.height); @@ -37,8 +40,6 @@ describe("hi", () => { const maxBounds = app.browserWindow.getBounds(); console.log('Max Window Size:', maxBounds.width, maxBounds.height); - await app.start(); - await app.client.waitUntilWindowLoaded(); }); after(() => { From 7e1bfa36e5e08a85c277b407985e877421fe3294 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Mon, 10 Feb 2020 11:04:34 -0700 Subject: [PATCH 14/15] timeout --- se2e/test.e2e-spec.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/se2e/test.e2e-spec.ts b/se2e/test.e2e-spec.ts index 7651254..68aa269 100644 --- a/se2e/test.e2e-spec.ts +++ b/se2e/test.e2e-spec.ts @@ -31,7 +31,9 @@ describe("hi", () => { await app.start(); await app.client.waitUntilWindowLoaded(); - + + await new Promise((resolve) => setTimeout(resolve, 30000)); + const bounds = app.browserWindow.getBounds(); console.log('Window Size:', bounds.width, bounds.height); From 024f16cfec00ae2b4d97fb757a0dea54c48bae07 Mon Sep 17 00:00:00 2001 From: Wade Wilkey Date: Mon, 10 Feb 2020 11:16:40 -0700 Subject: [PATCH 15/15] await --- se2e/test.e2e-spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/se2e/test.e2e-spec.ts b/se2e/test.e2e-spec.ts index 68aa269..422757b 100644 --- a/se2e/test.e2e-spec.ts +++ b/se2e/test.e2e-spec.ts @@ -34,12 +34,12 @@ describe("hi", () => { await new Promise((resolve) => setTimeout(resolve, 30000)); - const bounds = app.browserWindow.getBounds(); + const bounds = await app.browserWindow.getBounds(); console.log('Window Size:', bounds.width, bounds.height); app.browserWindow.maximize(); - const maxBounds = app.browserWindow.getBounds(); + const maxBounds = await app.browserWindow.getBounds(); console.log('Max Window Size:', maxBounds.width, maxBounds.height); });