Automatic todo symbol insertion

[vycdev]

Original author: michaelr
Original created at: 2019-04-12T18:10:41Z
Original URL: fabiospampinato#187

---

This would make it faster to create new tasks.

I'm i'm typing a task like this:
☐ task

Then press I enter, the next line should default to a task like this:
☐ task
☐ <-- cursor is here

[vycdev]

Original comment by fabiospampinato at 2019-04-12T19:23:49Z:

Sounds like a good addition, I'm not sure if I'd want to use that though 🤔 It may complicate things a little when you want to add a new todo indented differently.

I'd be happy to consider a PR that adds an option for implementing this 👍

[vycdev]

Original comment by LuisARodr at 2019-04-17T22:57:27Z:

I'll be taking a look at this issue.

[vycdev]

Original comment by OiYouYeahYou at 2019-04-24T16:53:22Z:

Coming from word processors and good markdown editors, I expect when on an existing todo and hitting enter another todo is added, like bullet points. Implementation wise, I would be happy with an opt-in setting for this behaviour as most I've spoken to haven't understood why this is a preference.

Here's my expected behaviour:

• Single enter add a new todo
• Double enter or Enter on a blank todo remove added todo and begin para
• Shift enter don't add todo and remain at previous task indent
• Possibly on save remove blank todos

[vycdev]

Original comment by fabiospampinato at 2019-04-25T17:20:37Z:

@OiYouYeahYou feel free to submit a PR implementing that. I'd leave out the automatic formatting/cleanup on save though, as it seems out of scope.

[vycdev]

Original comment by LuisARodr at 2019-04-25T17:50:01Z:

@fabiospampinato @OiYouYeahYou I'm working on those features, I'm going to open a pull request of the issue as a WIP.

[vycdev]

Original comment by LuisARodr at 2019-04-29T22:32:01Z:

Currently working on the PR, here is my progress so far:

Current features:

• Added new configuration todo.automaticSymbol

  "todo.automaticSymbol": false // Automatically insert new todo symbols and remove them when pressing enter"
  

• When an enter is pressed and you're currently on an empty todo; it deletes the empty todo.

• When an enter is pressed and you're currently on an filled todo; it creates an empty todo next line.

Missing:

• Using shift+enter to make a new line from a filled todo without creating an empty todo.

Any changes or suggestions are accepted

[vycdev]

Original comment by LuisARodr at 2019-04-30T17:22:06Z:

Hello, working on the shift+enter command I noticed some things, the moment you bind shift+enter to a command it stops making a new line, so I tried to insert a new line inside the command, and this came with some consequences:

• The cursor does not moves to the new line
• There is no indentation on the new line

And while this should be doable, its gonna change a lot of code.

A suggestion I have is to make the shift+enter command a toggle for the Automatic Todo Insertion Mode
This mode will be by default on Manual (how things are now)
And when turn on it will have the features of adding new todos when hitting enter on an filled todo or removing an empty todo.
This will also remove the need of having the option on the settings.

But this is just a suggestion and I can see how it could over-complicate things, gonna be working on making the new line from code to add the functionality to the command.

[vycdev]

Original comment by michaelr at 2019-04-30T18:02:42Z:

Are you using the LanguageConfiguration onEnterRules to do this?
https://code.visualstudio.com/api/references/vscode-api#LanguageConfiguration

On Tue, Apr 30, 2019 at 12:22 PM Luis Angel Rodriguez Guerrero <
notifications@github.com> wrote:

Hello, working on the shift+enter command I noticed some things, the
moment you bind shift+enter to a command it stops making a new line, so I
tried to insert a new line inside the command, and this came with some
consequences:

• The cursor does not moves to the new line
• There is no indentation on the new line

And while this should be doable, its gonna change a lot of code.

A suggestion I have is to make the shift+enter command a toggle for the
Automatic Todo Insertion Mode
This mode will be by default on Manual (how things are now)
And when turn on it will have the features of adding new todos when
hitting enter on an filled todo or removing an empty todo.
This will also remove the need of having the option on the settings.

But this is just a suggestion and I can see how it could over-complicate
things, gonna be working on making the new line from code to add the
functionality to the command.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
fabiospampinato#187 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAZT7XZO7VUYI45MIM7GLDPTB535ANCNFSM4HFST2RQ
.

[vycdev]

Original comment by LuisARodr at 2019-04-30T19:27:42Z:

No, I'm using onDidChangeTextDocument to catch a new line change, looking at onEnterRules it seems like it might be possible to use it for inserting a todo when an enter is pressed, but I don't see how it can remove a empty todo, or help to recognize a Shift+Enter without keybinding a command.

[vycdev]

Original comment by michaelr at 2019-04-30T21:08:26Z:

if you bind shift+enter and call editor.action.insertLineAfter it seems to
preserve the indentation and move the cursor.

On Tue, Apr 30, 2019 at 2:27 PM Luis Angel Rodriguez Guerrero <
notifications@github.com> wrote:

No, I'm using onDidChangeTextDocument to catch a new line change, looking
at onEnterRules it seems like it might be possible to use it for
inserting a todo when an enter is pressed, but I don't see how it can
remove a empty todo, or help to recognize a Shift+Enter without
keybinding a command.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
fabiospampinato#187 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAZT7WFVXRCQO4FFL6EOFLPTCMS7ANCNFSM4HFST2RQ
.

[vycdev]

Original comment by LuisARodr at 2019-04-30T23:24:08Z:

Currently on the PR#189 there is a functioning version of the feature, there is still a small issue I'll be taking a look.

[vycdev]

Original comment by LuisARodr at 2019-05-01T19:40:58Z:

@fabiospampinato Just finished the PR for the issue, if there are any changes that need to be done I'll come back to do them.

[vycdev]

Original comment by fabiospampinato at 2019-05-01T19:56:02Z:

@LuisARodr Thanks, I'll take a look at that as soon as I can 👍