Skip to content

sponsoredBadgeLabel added as a required prop  #389

@bruno-monteiro1

Description

@bruno-monteiro1

Describe the bug
The prop sponsoredBadgeLabel was added to the ProductSummaryName component, but not as optional, even though the component to which it passes on receives it as optional. This change got release as a minor (2.87.0), but breaks TS build on projects that depend on this.

To Reproduce
No need to reproduce, just check the sponsoredBadgeLabel typing on the ProductSummaryName component and see that it is required. Than, check that it is optional in the only component it gets passed on.

Expected behavior
The expected behaviour is that the prop is set as optional, not only because it is optional in the component it gets passed on, but also because it did not exist in previous versions of the same major.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions