fix: add validity no_nulls and fix usage (#7487)

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-array/public-api.lock

@@ -19038,6 +19038,8 @@ pub fn vortex_array::validity::Validity::mask_eq(&self, other: &vortex_array::va
 
 pub fn vortex_array::validity::Validity::maybe_len(&self) -> core::option::Option<usize>
 
+pub fn vortex_array::validity::Validity::no_nulls(&self) -> bool
+
 pub fn vortex_array::validity::Validity::not(&self) -> vortex_error::VortexResult<Self>
 
 pub fn vortex_array::validity::Validity::nullability(&self) -> vortex_array::dtype::Nullability

vortex-array/src/arrow/record_batch.rs

@@ -17,7 +17,6 @@ use crate::VortexSessionExecute;
 use crate::array::IntoArray;
 use crate::arrays::StructArray;
 use crate::arrow::ArrowArrayExecutor;
-use crate::validity::Validity;
 
 // deprecated(note = "Use ArrowArrayExecutor::execute_record_batch instead")
 impl TryFrom<&ArrayRef> for RecordBatch {
@@ -29,7 +28,7 @@ impl TryFrom<&ArrayRef> for RecordBatch {
         };
 
         vortex_ensure!(
-            matches!(struct_array.validity()?, Validity::AllValid),
+            struct_array.validity()?.no_nulls(),
             "RecordBatch can only be constructed from StructArray with no nulls"
         );
 

vortex-array/src/validity.rs

@@ -112,6 +112,13 @@ impl Validity {
         }
     }
 
+    /// Returns `true` if this validity guarantees no null values, i.e. it is either
+    /// [`Validity::NonNullable`] or [`Validity::AllValid`].
+    #[inline]
+    pub fn no_nulls(&self) -> bool {
+        matches!(self, Self::NonNullable | Self::AllValid)
+    }
+
     /// The union nullability and validity.
     #[inline]
     pub fn union_nullability(self, nullability: Nullability) -> Self {