Questionable URL construction

[vokal-isaac]

From

Cat2Cat/Cat2Cat/VICatalogWalker.m

Lines 84 to 91 in 8dc941b

	//Since we're converting to an NSURL, use percent-escape encoding or spaces will crash.
	path = [path stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
	//Make sure to skip hidden files
	NSArray *folderContents = [self.fileManager contentsOfDirectoryAtURL:[NSURL URLWithString:path]
	includingPropertiesForKeys:@[NSURLNameKey]
	options:NSDirectoryEnumerationSkipsHiddenFiles
	error:&folderError];

:

    //Since we're converting to an NSURL, use percent-escape encoding or spaces will crash.
    path = [path stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];

    //Make sure to skip hidden files
    NSArray *folderContents = [self.fileManager contentsOfDirectoryAtURL:[NSURL URLWithString:path]
                                              includingPropertiesForKeys:@[NSURLNameKey]
                                                                 options:NSDirectoryEnumerationSkipsHiddenFiles
                                                                   error:&folderError];

This should probably be something like:

    //Make sure to skip hidden files
    NSArray *folderContents = [self.fileManager contentsOfDirectoryAtURL:[NSURL fileURLWithPath:path]
                                              includingPropertiesForKeys:@[NSURLNameKey]
                                                                 options:NSDirectoryEnumerationSkipsHiddenFiles
                                                                   error:&folderError];

(h/t @bryanluby)

[designatednerd]

@vokal-isaac @bryanluby Open a PR then 😄

[vokal-isaac]

This was mostly a reminder for whenever someone has the time to validate it and open that PR.