Skip to content

connection.algorithms are not used for terminal access #5

@GitMensch

Description

@GitMensch

The terminal creation at https://github.com/vorfol/vms-ide/blob/af1bc0dd2bd7fbf8b94cedf02079dddf0868182b/src/vms_debug/ui/terminal.ts#L71 and https://github.com/vorfol/vms-ide/blob/af1bc0dd2bd7fbf8b94cedf02079dddf0868182b/src/vms_debug/ui/terminal.ts#L98 is hard-wired concerning the connection.algorithms.

Please include not only ${port} ${userName}@${host but also the connection algorithms. As this part (and the port, user, server) are used identical twice I suggest to have a static function to to return those as string.

To ease passing those to the starting functions I suggest to not pass single connection members in https://github.com/vorfol/vms-ide/blob/af1bc0dd2bd7fbf8b94cedf02079dddf0868182b/src/vms_debug/extension.ts#L149-L156 (where I see the keyfile gets a different start call, so that is handled separately already), but the connection opject itself.

Additional note:
cipher seems to be defined, but never used in the source (or github was not able to find it).

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions