Iteration6: Refactor magic strings and printer patterns

Fix small typo in test

Author: vfarah-if

test-pnpm/shopping-cart-kata/README.md

@@ -199,3 +199,7 @@ You could start Outside-In **only** if:
 - You're willing to mock deeper domain types (`Product`, `CartItem`, etc.)
 
 But in this kata, that’s harder to justify because the logic in the "leaf" types is richer and more test-worthy than in the orchestration layer.
+
+### Summary
+
+Thnanks Emmanuael Valverde, for your cool takle on this [kata](https://www.codurance.com/katas/shopping-cart-kata). There were a few sneaky catches with the pricing. I have done this kata before using simple types and I found myself producing more code this time. I also did outside in, before, mocking and faking bits until I had the final design. I think breaking this up into  the seperate phases made it easier to get my head around each concept, so I am glad I did it this way. The thing didn't like is it forced me into a solution by virtue of what I simplified. It may be a good or bad thing, no idea. 

test-pnpm/shopping-cart-kata/constants.ts

@@ -0,0 +1,15 @@
+
+export const TABLE_CONSTANTS = {
+  LINE_WIDTH: 44,
+  COLUMN_WIDTHS: {
+    NAME: 12,
+    PRICE: 14,
+    QUANTITY: 8,
+  },
+  PADDING_WIDTH: 40,
+  CURRENCY: '€',
+  SEPARATORS: {
+    HORIZONTAL: '-',
+    VERTICAL: '|',
+  },
+};

test-pnpm/shopping-cart-kata/discount.should.test.ts

@@ -14,7 +14,7 @@ describe('Discount should', () => {
     expect(discount).toBeNull();
   });
 
-  it('alculate a discount from a price', () => {
+  it('calculate a discount from a price', () => {
     const discount = Discount.fromCode('PROMO_10')!;
     expect(discount.applyTo(100)).toBe(90);
   });

test-pnpm/shopping-cart-kata/printer.ts

@@ -1,4 +1,5 @@
 import { CartItem } from './cartItem';
+import { TABLE_CONSTANTS } from './constants';
 import { Discount } from './discount';
 
 export interface TablePrinter {
@@ -11,49 +12,73 @@ export interface TablePrinter {
   printHeaderFooter(): string;
 }
 
-export class InMemoryTablePrinter implements TablePrinter {
+export class DefaultTablePrinter implements TablePrinter {
   printHeader(): string {
     return [
-      '--------------------------------------------',
-      '| Product name | Price with VAT | Quantity |',
-      '| ------------ | -------------- | -------- |',
+      this.printLineSeparator(),
+      `${TABLE_CONSTANTS.SEPARATORS.VERTICAL} Product name ${TABLE_CONSTANTS.SEPARATORS.VERTICAL} Price with VAT ${TABLE_CONSTANTS.SEPARATORS.VERTICAL} Quantity ${TABLE_CONSTANTS.SEPARATORS.VERTICAL}`,
+      `${TABLE_CONSTANTS.SEPARATORS.VERTICAL} ${'-'.repeat(TABLE_CONSTANTS.COLUMN_WIDTHS.NAME)} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL} ${'-'.repeat(TABLE_CONSTANTS.COLUMN_WIDTHS.PRICE)} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL} ${'-'.repeat(TABLE_CONSTANTS.COLUMN_WIDTHS.QUANTITY)} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL}`,
     ].join('\n');
   }
 
   printHeaderFooter(): string {
-    return '|------------------------------------------|';
+    return `${TABLE_CONSTANTS.SEPARATORS.VERTICAL}${'-'.repeat(TABLE_CONSTANTS.LINE_WIDTH - 2)}${TABLE_CONSTANTS.SEPARATORS.VERTICAL}`;
   }
 
   printCartItem(item: CartItem): string {
-    const name = item.product.name.padEnd(12);
-    const priceWithVat = `${item.product.finalPrice.toFixed(2)} €`.padEnd(14);
-    const quantity = item.quantity.toString().padEnd(8);
+    const name = item.product.name.padEnd(TABLE_CONSTANTS.COLUMN_WIDTHS.NAME);
+    const priceWithVat =
+      `${this.formatPrice(item.product.finalPrice)} ${TABLE_CONSTANTS.CURRENCY}`.padEnd(
+        TABLE_CONSTANTS.COLUMN_WIDTHS.PRICE,
+      );
+    const quantity = item.quantity.toString().padEnd(TABLE_CONSTANTS.COLUMN_WIDTHS.QUANTITY);
 
-    return `| ${name} | ${priceWithVat} | ${quantity} |`;
+    return `${TABLE_CONSTANTS.SEPARATORS.VERTICAL} ${name} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL} ${priceWithVat} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL} ${quantity} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL}`;
   }
 
   printLineSeparator(): string {
-    return '--------------------------------------------';
+    return TABLE_CONSTANTS.SEPARATORS.HORIZONTAL.repeat(TABLE_CONSTANTS.LINE_WIDTH);
   }
 
   printPromotion(discount: Discount | null): string {
-    const promotionCode = discount?.code ?? '';
-    const promotionDescription =
-      discount != null
-        ? `Promotion: ${discount?.percentage * 100}% off with code ${promotionCode}`
-        : 'Promotion:';
-    return [this.printHeaderFooter(), `| ${promotionDescription.padEnd(40)} |`].join('\n');
+    const promotionDescription = this.formatPromotionDescription(discount);
+    return [
+      this.printHeaderFooter(),
+      `${TABLE_CONSTANTS.SEPARATORS.VERTICAL} ${promotionDescription.padEnd(TABLE_CONSTANTS.PADDING_WIDTH)} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL}`,
+    ].join('\n');
   }
 
   printProductCount(items: CartItem[]): string {
-    const totalItems = items.reduce((total, item) => total + item.quantity, 0);
-    return `| Total products: ${totalItems.toString().padEnd(24)} |`;
+    const totalItems = this.calculateTotalItems(items);
+    return `${TABLE_CONSTANTS.SEPARATORS.VERTICAL} Total products: ${totalItems.toString().padEnd(24)} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL}`;
   }
 
   printTotalPrice(items: CartItem[], discount: Discount | null): string {
-    const totalPrice = items.reduce((total, item) => total + item.LineTotal, 0);
+    const totalPrice = this.calculateTotalPrice(items);
     const discountedAmount = discount ? discount.applyTo(totalPrice) : totalPrice;
-    const description = `Total price: ${discountedAmount.toFixed(2)} €`;
-    return `| ${description.padEnd(40)} |`;
+    const description = `Total price: ${this.formatPrice(discountedAmount)} ${TABLE_CONSTANTS.CURRENCY}`;
+
+    return `${TABLE_CONSTANTS.SEPARATORS.VERTICAL} ${description.padEnd(TABLE_CONSTANTS.PADDING_WIDTH)} ${TABLE_CONSTANTS.SEPARATORS.VERTICAL}`;
+  }
+
+  private formatPromotionDescription(discount: Discount | null): string {
+    if (discount == null) {
+      return 'Promotion:';
+    }
+
+    const percentage = Math.round(discount.percentage * 100);
+    return `Promotion: ${percentage}% off with code ${discount.code}`;
+  }
+
+  private calculateTotalItems(items: CartItem[]): number {
+    return items.reduce((total, item) => total + item.quantity, 0);
+  }
+
+  private calculateTotalPrice(items: CartItem[]): number {
+    return items.reduce((total, item) => total + item.LineTotal, 0);
+  }
+
+  private formatPrice(price: number): string {
+    return price.toFixed(2);
   }
 }

test-pnpm/shopping-cart-kata/shoppingCart.ts

@@ -1,7 +1,7 @@
 import { CartItem } from './cartItem';
 import { Discount } from './discount';
 import { Logger } from './logger';
-import { InMemoryTablePrinter, TablePrinter } from './printer';
+import { DefaultTablePrinter, TablePrinter } from './printer';
 
 export interface ShoppingCart {
   addItem(cartItem: CartItem): void;
@@ -12,7 +12,7 @@ export interface ShoppingCart {
 export class InMemoryShoppingCart implements ShoppingCart {
   private items: CartItem[] = [];
   private discounts: Discount[] = [];
-  private printer: TablePrinter = new InMemoryTablePrinter();
+  private printer: TablePrinter = new DefaultTablePrinter();
 
   constructor(private logger: Logger) {}