Shellcheck issues

[bluppfisk]

1. Shellcheck fails quietly if it doesn't exist, this should be communicated to the user
2. After installing shellcheck and running vet with its own install script, I get:

==> Running ShellCheck analysis...
/tmp/tmp.DW0MrHbHxq: /tmp/tmp.DW0MrHbHxq: openBinaryFile: does not exist (No such file or directory)

Looks like it should point to a different file..

[lykhvar]

Thanks for reporting this. You're right, this looks like an issue with how temporary files are handled. I'll try to reproduce it and will post my findings here.

[lykhvar]

Sorry for the delay.

The script already checks for shellcheck, so let's set that part aside and focus on the specific openBinaryFile: does not exist error. I haven't been able to reproduce this myself, but my leading theory is that it's a race condition. The error can occur if the process is interrupted (e.g., by pressing Ctrl+C) at the exact moment shellcheck is analyzing the temporary file.

This triggers two events that race against each other:

• vet's cleanup trap fires immediately, deleting the temporary file to ensure a safe exit.
• The shellcheck process, also reacting to the interruption, tries to finish its work but fails when it discovers the file it was reading has suddenly vanished.

Could you please help me confirm this, by running command again, this time letting it complete without any interruption.

• If the error does not happen, it confirms the race condition theory.
• If the error still happens consistently without any interruption, then there is a different, deeper bug that we need to investigate.

Thanks again for your help in tracking this down!

[bluppfisk]

Hi Artem, I've never used ctrl-c to interrupt the process so I don't think it's that.

With respect to the check for shellcheck: vet is advertised as checking the code for potential problematic behaviour, but then it also quietly skips shellcheck if it cannot find the binary. That seems something to address or at least communciate to the user. (But I agree that this should be a separate issue)