client_os is not reported properly

[scherepanov]

Hi,

Here is how client_os is reported in sessions, user_sessions, dc_user_sessions:

client_type client_version client_os

JDBC Driver 09.02.0000 Windows 11 10.0 amd64
vertica-sql-go 1.1.1
vertica-python 1.1.1 Linux-4.16.13-300.fc28.x86_64-x86_64-with-fedora-28-Twenty_Eight
vertica-python 1.1.1 Linux-4.18.0-193.6.3.el8_2.x86_64-x86_64-with-glibc2.28
vertica-python 1.1.1 Linux-4.16.13-300.fc28.x86_64-x86_64-with-fedora-28-Twenty_Eight
Node.js Driver 1.1.3 win32
Node.js Driver 1.1.3 linux
Node.js Driver 1.1.3 linux
Node.js Driver 1.1.3 win32
vertica-sql-go 1.3.0
vertica-python 1.4.0 Linux-4.16.13-300.fc28.x86_64-x86_64-with-glibc2.27

Vertica-python is doing great job on reporting client_os, showing same value as vsql, ODBC and JDBC drivers.

Node.js is super minimalistic

vertica-sql-go does not bother.

Is it possible to bring reporting of os_version to same standards as Vertica vsql, ODBC and JDBC drivers?

Thank you
Sergey

[h-serizawa]

Currently, it uses os.platform()'s output as the client_os value. To set a similar value to the vsql's one, it needs to use os.type(), os.release(), and os.machine() as follows. The value should be the same in the Linux environment.

> [os.type(), os.release(), os.machine()].join(' ');
'Linux 5.14.0-570.18.1.el9_6.x86_64 x86_64'

> [os.type(), os.release(), os.machine()].join(' ');
'Windows_NT 10.0.14393 x86_64'

However, CI failed in Node.js 12 and 14 because there is no os.machine() function in them. os.arch() may be enough to replace os.machine().

[scherepanov]

@h-serizawa
Thank you, please merge into master.
Would be nice to get notice when new version with fix will be released.