test(jq): strengthen string key shorthand tests with AST assertions and edge cases

- Assert entry count, key strings, and Field node shape in parser tests
- Add non-identifier key tests: hyphenated ("a-b"), numeric ("1"), empty ("")
- Add regression test for explicit key-value with string key ("name": .x)
- Add comparison tests for non-identifier key shorthands
- Extract expectShorthandEntry() helper to reduce duplication

Author: skoblenick

src/commands/jq/jq.string-key-shorthand.test.ts

@@ -1,47 +1,104 @@
 import { describe, expect, it } from "vitest";
 import { Bash } from "../../Bash.js";
 import { parse } from "../query-engine/parser.js";
+import type { ObjectNode } from "../query-engine/parser-types.js";
+
+function expectShorthandEntry(
+  entry: ObjectNode["entries"][number],
+  keyName: string,
+) {
+  expect(entry.key).toBe(keyName);
+  expect(entry.value).toEqual({ type: "Field", name: keyName });
+}
 
 describe("jq string key shorthand in object construction", () => {
   describe("parser: quoted string keys without colon", () => {
-    it('should parse {"name"} as shorthand', () => {
-      const ast = parse('{"name"}');
+    it('should parse {"name"} as shorthand with correct AST', () => {
+      const ast = parse('{"name"}') as ObjectNode;
       expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "name");
     });
 
-    it('should parse {"name", "label"} as shorthand', () => {
-      const ast = parse('{"name", "label"}');
+    it('should parse {"name", "label"} as shorthand with correct AST', () => {
+      const ast = parse('{"name", "label"}') as ObjectNode;
       expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(2);
+      expectShorthandEntry(ast.entries[0], "name");
+      expectShorthandEntry(ast.entries[1], "label");
     });
 
     it('should parse {"if"} as shorthand (keyword as string key)', () => {
-      const ast = parse('{"if"}');
+      const ast = parse('{"if"}') as ObjectNode;
       expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "if");
     });
 
     it('should parse {"as"} as shorthand (keyword as string key)', () => {
-      const ast = parse('{"as"}');
+      const ast = parse('{"as"}') as ObjectNode;
       expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "as");
     });
 
     it('should parse {"try"} as shorthand (keyword as string key)', () => {
-      const ast = parse('{"try"}');
+      const ast = parse('{"try"}') as ObjectNode;
       expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "try");
     });
 
     it('should parse {"true"} as shorthand (keyword as string key)', () => {
-      const ast = parse('{"true"}');
+      const ast = parse('{"true"}') as ObjectNode;
       expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "true");
     });
 
     it('should parse {"null"} as shorthand (keyword as string key)', () => {
-      const ast = parse('{"null"}');
+      const ast = parse('{"null"}') as ObjectNode;
       expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "null");
     });
 
     it('should parse mixed: {"name", "label": .x}', () => {
-      const ast = parse('{"name", "label": .x}');
+      const ast = parse('{"name", "label": .x}') as ObjectNode;
+      expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(2);
+      expectShorthandEntry(ast.entries[0], "name");
+      expect(ast.entries[1].key).toBe("label");
+      expect(ast.entries[1].value).toEqual({ type: "Field", name: "x" });
+    });
+
+    it('should parse non-identifier key {"a-b"} as shorthand', () => {
+      const ast = parse('{"a-b"}') as ObjectNode;
+      expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "a-b");
+    });
+
+    it('should parse numeric string key {"1"} as shorthand', () => {
+      const ast = parse('{"1"}') as ObjectNode;
+      expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "1");
+    });
+
+    it('should parse empty string key {""} as shorthand', () => {
+      const ast = parse('{""}') as ObjectNode;
+      expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expectShorthandEntry(ast.entries[0], "");
+    });
+
+    it("should still parse explicit key-value with string key", () => {
+      const ast = parse('{"name": .x}') as ObjectNode;
       expect(ast.type).toBe("Object");
+      expect(ast.entries).toHaveLength(1);
+      expect(ast.entries[0].key).toBe("name");
+      expect(ast.entries[0].value).toEqual({ type: "Field", name: "x" });
     });
   });
 
@@ -104,5 +161,32 @@ describe("jq string key shorthand in object construction", () => {
       expect(result.exitCode).toBe(0);
       expect(result.stdout).toBe('{"name":"foo","label":"bar"}\n');
     });
+
+    it('should evaluate non-identifier key {"a-b"} shorthand', async () => {
+      const env = new Bash();
+      const result = await env.exec(
+        `echo '{"a-b":"val","extra":"x"}' | jq -c '{"a-b"}'`,
+      );
+      expect(result.exitCode).toBe(0);
+      expect(result.stdout).toBe('{"a-b":"val"}\n');
+    });
+
+    it('should evaluate numeric string key {"1"} shorthand', async () => {
+      const env = new Bash();
+      const result = await env.exec(
+        `echo '{"1":"val","extra":"x"}' | jq -c '{"1"}'`,
+      );
+      expect(result.exitCode).toBe(0);
+      expect(result.stdout).toBe('{"1":"val"}\n');
+    });
+
+    it('should evaluate empty string key {""} shorthand', async () => {
+      const env = new Bash();
+      const result = await env.exec(
+        `echo '{"":"val","extra":"x"}' | jq -c '{""}'`,
+      );
+      expect(result.exitCode).toBe(0);
+      expect(result.stdout).toBe('{"":"val"}\n');
+    });
   });
 });

src/comparison-tests/fixtures/jq.comparison.fixtures.json

@@ -62,6 +62,15 @@
     "stderr": "",
     "exitCode": 0
   },
+  "348c7a17b8cc0a03": {
+    "command": "jq -c '{\"\"}'  data.json",
+    "files": {
+      "data.json": "{\"\":\"val\",\"extra\":\"x\"}"
+    },
+    "stdout": "{\"\":\"val\"}\n",
+    "stderr": "",
+    "exitCode": 0
+  },
   "3a5bd13032387ef1": {
     "command": "jq 'reverse' data.json",
     "files": {
@@ -116,6 +125,15 @@
     "stderr": "",
     "exitCode": 0
   },
+  "889ffd5c41c5b865": {
+    "command": "jq -c '{\"a-b\"}' data.json",
+    "files": {
+      "data.json": "{\"a-b\":\"val\",\"extra\":\"x\"}"
+    },
+    "stdout": "{\"a-b\":\"val\"}\n",
+    "stderr": "",
+    "exitCode": 0
+  },
   "91c885f22f4323a6": {
     "command": "jq '.' data.json",
     "files": {
@@ -265,6 +283,15 @@
     "stderr": "",
     "exitCode": 0
   },
+  "f3069be0bd4e62b6": {
+    "command": "jq -c '{\"1\"}' data.json",
+    "files": {
+      "data.json": "{\"1\":\"val\",\"extra\":\"x\"}"
+    },
+    "stdout": "{\"1\":\"val\"}\n",
+    "stderr": "",
+    "exitCode": 0
+  },
   "f9870901c3117349": {
     "command": "jq -c '{\"if\"}' data.json",
     "files": {

src/comparison-tests/jq.comparison.test.ts

@@ -268,6 +268,27 @@ describe("jq command - Real Bash Comparison", () => {
         `jq -c '{"name", "v": .value}' data.json`,
       );
     });
+
+    it('should handle non-identifier key {"a-b"} shorthand', async () => {
+      const env = await setupFiles(testDir, {
+        "data.json": '{"a-b":"val","extra":"x"}',
+      });
+      await compareOutputs(env, testDir, `jq -c '{"a-b"}' data.json`);
+    });
+
+    it('should handle numeric string key {"1"} shorthand', async () => {
+      const env = await setupFiles(testDir, {
+        "data.json": '{"1":"val","extra":"x"}',
+      });
+      await compareOutputs(env, testDir, `jq -c '{"1"}' data.json`);
+    });
+
+    it('should handle empty string key {""} shorthand', async () => {
+      const env = await setupFiles(testDir, {
+        "data.json": '{"":"val","extra":"x"}',
+      });
+      await compareOutputs(env, testDir, `jq -c '{""}'  data.json`);
+    });
   });
 
   describe("string functions", () => {