Skip to content

Refactor Validation class #69

@SaritNike

Description

@SaritNike

Currently the PyNomaly library is using a validation class that offers several methods that print a warning and return a bool. Based on the returned bool value we either call some other function or even call sys.exit(). The following things should be changed:

  1. Rename methods: functions like _fit() should be renamed to indicate that it only checks something e.g. is_fit()
  2. Consider whether a validation class is even necessary, since all except for one of it's methods are static
  3. Throw proper, meaningful exceptions instead of calling sys.exit() if certain validation methods

Metadata

Metadata

Assignees

Labels

enhancementNew feature of request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions