-
Notifications
You must be signed in to change notification settings - Fork 4
Better cloning for td-builder.service.ts #58
Copy link
Copy link
Open
Labels
effort: hoursgood first issue 👍Good for newcomersGood for newcomerspriority: low (4)Low-priority issue that needs to be resolvedLow-priority issue that needs to be resolvedscope: introductiontype: enhancementNew feature or requestNew feature or request
Description
As introduced by #52, the td-builder.service.ts now use the usual trick of JSON.stringify and parse to clone the TD model and generate a valid Thing Description. Is there a better way to achieve this? Is this really performance critical?
Tracking
zion/src/introduction/td-builder.service.ts
Lines 25 to 26 in cc5a16a
| // FIXME: Get rid of this workaround. | |
| const clonedModel = JSON.parse(JSON.stringify(model)); |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
effort: hoursgood first issue 👍Good for newcomersGood for newcomerspriority: low (4)Low-priority issue that needs to be resolvedLow-priority issue that needs to be resolvedscope: introductiontype: enhancementNew feature or requestNew feature or request