Router.sol - What is "fraction" use for?

[tcheee]

I see that there is an uint256 in the "StoreOperation" struct but it is not used. What will it be used for?

[pgbrandao]

fraction has not been implemented yet, but the idea is simple: when fetching a store, fraction will allow to use only a certain percentage of the value. (Since the EVM doesn't have a floating point type, it will have a denominator of 1000000 or something similar.)

[tcheee]

@pgbrandao so it would be a way to move from various decimals type? Like transforming a value from 10 ** 6 to 10 ** 18?

[pgbrandao]

The fraction field is a way to facilitate operations that use only a portion of a stored value, specified as a percentage. For example, if you have a sequence of exchanges—you want to convert 100% of token A into token B, then split the resulting amount of token B, converting 50% into token C and keeping the remainder in token B—fraction allows you to specify these percentages. The EVM doesn't support floating-point arithmetic, so fraction will use a denominator (such as 1000000) to represent these percentages with high precision.

I have roughly implemented this idea on this commit: b878605

[tcheee]

Ok ok I see, thanks for the clarification!