[Bug] File encoding for .orh files doesn't work properly even when running under UTF-8 mode

[MuTsunTsai]

It is quite known that ORIHIME's own file format (*.orh) files could have encoding issues in various environment, yet I'm not aware of an existing solution. After some experiment I came up with the following command to start ORIHIME that can solve the problem:

java -Dfile.encoding=utf-8 -jar [path/filename of your orihime.jar or orihimeMod.jar]

As can be seen in the first picture, for the original ORIHIME (not the mod), the output file is then perfectly encoded. However, things are not exactly so for OrihimeMod, as can be seen in the second picture.

This doesn't stop the file from reopening though, as long as the file is also output by OrihimeMod itself. But, even when running under UTF-8 mode, Orihime and OrihimeMode cannot open files saved by the other. I guess something didn't go quite right when you compile OrihimeMod, see if you could investigate into this.

[undertrox]

Thanks for reporting!

You're right, the difference between the mod and the original orihime is caused by compiling with a wrong encoding. The orihime3.054.jar in this repo was slightly modified and recompiled by me to add the self intersection highlighting feature, and I seem to have used another encoding than the source files were originally in. OrihimeMod versions from before that feature was introduced (0.3.1 and older) should encode the files properly as well with your fix.

I'm currently working on a new version of orihimeMod that uses orihime 3.060 as the "base", and I'm trying to find a way to implement the self intersection highlighting without having to recompile the original jar. If I can do that, this issue should be fixed. In that version I also already modified the saving and loading code to use utf-8 by default, so then it should even work without -Dfile.encoding=utf-8.

[MuTsunTsai]

Looking forward to it! By the way, I noticed this bug when I was trying to figure out the format of .orh files so that I might incorporate it into my Box Pleating Studio in the future. I was like 😅 when I realized that Mr. Meguro actually used a mixture of Japanese and its Romanization as the format spec... But oh well.