Bug: SolidJS effect does not get triggered on setter

[Shinigami92]

Code:

unuse/packages/unuse-solid/src/index.ts

Lines 138 to 150 in 8f238f9

	const state = createSolidSignal(signal.get());
	if (!readonly) {
	createSolidEffect(() => {
	const value = state[0]();
	signal.set(value);
	});
	}
	unEffect(() => state[1](() => signal.get()));
	// @ts-expect-error: just do it
	return readonly ? state[0] : state;

Test:

unuse/packages/unuse-solid/src/index.spec.ts

Lines 54 to 66 in 8f238f9

	it.todo('should resolve an UnSignal to a Solid Signal', () => {
	const mySignal = unSignal(42);
	renderHook(() => {
	const resolved = unResolve(mySignal);
	expect(resolved[0]()).toBe(42);
	resolved[1](100);
	return resolved;
	});
	expect(mySignal.get()).toBe(100);
	});

expect(mySignal.get()).toBe(100); results in 42 instead of 100.

@ryansolid could you maybe explain why the createSolidEffect gets triggered? And can I somehow trigger it?

[XiNiHa]

Have you tried using createComputed instead of createEffect? The effect is mainly for actual side effects on the leaf of the tree. createComputed should be used for derived values like this case.

[Shinigami92]

Thanks! I will investigate more about that. We need tips like that from the community ❤️

[Shinigami92]

Only partly related to the issue, but I just found out that I fundamentally misunderstood SolidJS createMemo 🤯
createMemo does by far not work as computed in Vue, because it eager loads and reruns always on dependency changes, even when not read.

I read now multiple articles to find out how things could work better:

• https://docs.solidjs.com/reference/basic-reactivity/create-memo
• https://stackoverflow.com/questions/76855095/in-solidjs-how-to-avoid-multi-execution-of-the-computed-when-the-dependencies-h

But there is a SolidJS v2 in plan with lazy memo

• The Road to 2.0 solidjs/solid#2425

So maybe with that, things might work better, but when I look into the pace of the solid project... this may take a while 😐