Skip to content

Conversation

@reedacartwright
Copy link
Contributor

SHA256 is considered more secure that MD5, so it is a good idea to use it to validate our testdata.tar.gz download.

At the same time, create a make_testdata_sum target to simplify the calculation of the SHA256, e.g.

  1. Commit new testing data to the testdata repo.
  2. Identify the commit id of the updated testdata repo
  3. Edit the TESTDATA_COMMIT in test/CMakeList.txt to reflect the new id.
  4. Run make make_testdata_sum to calculate the SHA256 of the data
  5. Paste the result into TESTDATA_SHA256 in test/CmakeList.txt
  6. Run make testdata to verify that it works.

Add make_testdata_sum target to calculate SHA256 when the commitid changes.
reedacartwright added a commit that referenced this pull request Mar 3, 2016
@reedacartwright reedacartwright merged commit 85efe6d into ultimatesource:develop Mar 3, 2016
@reedacartwright reedacartwright deleted the feature/maketestdatasum branch June 23, 2016 03:52
@stevenhwu stevenhwu mentioned this pull request Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant